Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Shift+Up/Down do not work w/ Termion backend #758

Open
hrkfdn opened this issue Sep 23, 2023 · 2 comments
Open

[BUG] Shift+Up/Down do not work w/ Termion backend #758

hrkfdn opened this issue Sep 23, 2023 · 2 comments
Labels

Comments

@hrkfdn
Copy link

hrkfdn commented Sep 23, 2023

Describe the bug
Some bindings do not work with Termion, i.e. Shift+Up/Shift+Down. Shift+p for instance works. This is with the Termion backend on Linux using GNOME Terminal. TERM is set to xterm-256color.

Expected behavior
A clear and concise description of what you expected to happen.

Environment

  • Debian 12.1 with Linux 6.4.0
  • GNOME Terminal 3.46.8 using VTE 0.70.6 +BIDI +GNUTLS +ICU +SYSTEMD
  • Backend used: termion
  • Current locale: en_US.UTF-8
  • Cursive version: 0.20.0

Additional context

@hrkfdn hrkfdn added the bug label Sep 23, 2023
@gyscos
Copy link
Owner

gyscos commented Sep 29, 2023

Hi, and thanks for the report!

Indeed, it seems the termion backend doesn't currently support shift+arrow (or ctrl+arrow). It doesn't seem to be supported in termion itself.

Termion does return an "unsupported" key code, and we could parse these codes here, but in that case we'd pretty much be doing the backend library's job. I'm not entirely against that, but I slightly prefer the alternatives:

  • Properly report these events in termion itself, so we could support it in cursive.
  • Use another backend that supports these events, like crossterm.

@hrkfdn
Copy link
Author

hrkfdn commented Sep 30, 2023

Thanks, I have switched to Crossterm now, seems to work fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants