Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why did you move and hide everything inside a method? This removes any typing and any potential access to monkeypatch _Session (ie for celery) #25

Open
adiberk opened this issue Dec 2, 2024 · 0 comments
Open

Why did you move and hide everything inside a method? This removes any typing and any potential access to monkeypatch _Session (ie for celery) #25

adiberk opened this issue Dec 2, 2024 · 0 comments

Comments

@adiberk
Copy link

adiberk commented Dec 2, 2024

In v.5 it was easy to use this with celery without having to recreate fastapi app (which isn't needed for celery)
To do this we would Moneky patch the _Session object

Now that this variable is hidden in method, we can't do that (I don't think)
@adiberk adiberk changed the title No access to _Session for easy use with Celery without middleware initialization No access to _Session or the DBSession class for typing - No easy monkeypatch for celery usage Dec 4, 2024
@adiberk adiberk changed the title No access to _Session or the DBSession class for typing - No easy monkeypatch for celery usage Why did you move and hide everything inside a method? This removes any typing and any potential access to monkeypatch _Session (ie for celery) Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adiberk