-
Notifications
You must be signed in to change notification settings - Fork 319
Open
habitat-sh/builder
#1027Labels
Focus:SupervisorRelated to the Habitat Supervisor (core/hab-sup) componentRelated to the Habitat Supervisor (core/hab-sup) componentType:Technical DebtNo functional changes; just about cleaning up and reorganizingNo functional changes; just about cleaning up and reorganizing
Description
Links in bold are PRs in review. All tasks are @baumanj unless otherwise noted.
- Agree on lint standards
- Fix lints that cause errors
- Add clippy checking to CI
- Fix lints that cause warnings and upgrade them to error-causing
- habitat
- clippy::redundant_field_names
- clippy::needless_update
- clippy::len_without_is_empty
- clippy::wrong_self_convention
- clippy::trivially_copy_pass_by_ref
- clippy::needless_pass_by_value
- clippy::clippy::cyclomatic_complexity
- clippy::clippy::large_enum_variant
- clippy::clippy::needless_return (@christophermaier per
Classify the remaining unfixed clippy lints as ones to fix versus ignore #6100 (comment)) - clippy::clippy::too_many_arguments
- Changes for clippy lint fixes from core
- core
- Fix clippy lints
- Change
PackageTarget::active_target()to return non-reference - Make
PairTypeCopyand change references
- builder
- habitat
Metadata
Metadata
Labels
Focus:SupervisorRelated to the Habitat Supervisor (core/hab-sup) componentRelated to the Habitat Supervisor (core/hab-sup) componentType:Technical DebtNo functional changes; just about cleaning up and reorganizingNo functional changes; just about cleaning up and reorganizing