Clippy tracking issue

[baumanj]

Links in bold are PRs in review. All tasks are @baumanj unless otherwise noted.

• Agree on lint standards
• Fix lints that cause errors
  • habitat
  • core
  • builder
• Add clippy checking to CI
  • Share lint definitions across platforms
    • Linux
    • Windows (@mwrock)
  • Linux
    • habitat
    • core
    • builder
  • Windows (@mwrock)
    • habitat
    • core
    • builder
• Fix lints that cause warnings and upgrade them to error-causing
  • habitat
    • clippy::redundant_field_names
    • clippy::needless_update
    • clippy::len_without_is_empty
    • clippy::wrong_self_convention
    • clippy::trivially_copy_pass_by_ref
    • clippy::needless_pass_by_value
    • clippy::clippy::cyclomatic_complexity
    • clippy::clippy::large_enum_variant
    • clippy::clippy::needless_return (@christophermaier per
      Classify the remaining unfixed clippy lints as ones to fix versus ignore #6100 (comment))
    • clippy::clippy::too_many_arguments
    • Changes for clippy lint fixes from core
  • core
    • Fix clippy lints
    • Change PackageTarget::active_target() to return non-reference
    • Make PairType Copy and change references
  • builder
    • Changes for clippy lint fixes from core
    • Fix clippy lints and update CI