Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve read/write performance #21

Merged
merged 22 commits into from
Aug 14, 2024
Merged

Improve read/write performance #21

merged 22 commits into from
Aug 14, 2024

Conversation

halleysfifthinc
Copy link
Owner

  • Be less eager with slow get_multipled_parameter_names calls
  • Replace one transcode with a widen
  • strip before transcoding
  • Fix copy-pasta
  • Only create pt_labels if there are points to be labeled

@halleysfifthinc
Copy link
Owner Author

Benchmark Report for C3D.jl

Job Properties

  • Package commits:
    • Target: a7e9ea
    • Baseline: 258bf4

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). All results are shown below.

ID time ratio memory ratio
["read", "big", "sample12/c24089 13.c3d", "full"] 0.42 (5%) ✅ 0.81 (1%) ✅
["read", "big", "sample12/c24089 13.c3d", "params"] 1.11 (5%) ❌ 1.35 (1%) ❌
["read", "big", "sample15/FP1.C3D", "full"] 0.80 (5%) ✅ 0.72 (1%) ✅
["read", "big", "sample15/FP1.C3D", "params"] 1.06 (5%) ❌ 1.11 (1%) ❌
["read", "big", "sample17/128analogchannels.c2d", "full"] 0.72 (5%) ✅ 0.72 (1%) ✅
["read", "big", "sample17/128analogchannels.c3d", "params"] 1.06 (5%) ❌ 1.24 (1%) ❌
["read", "big", "sample19/sample19.c3d", "full"] 0.83 (5%) ✅ 0.67 (1%) ✅
["read", "big", "sample19/sample19.c3d", "params"] 1.06 (5%) ❌ 1.02 (1%) ❌
["read", "big", "sample31/large01.c3d", "full"] 0.79 (5%) ✅ 0.75 (1%) ✅
["read", "big", "sample31/large01.c3d", "params"] 1.05 (5%) ❌ 1.13 (1%) ❌
["read", "big", "sample33/bigparlove.c3d", "full"] 0.78 (5%) ✅ 0.82 (1%) ✅
["read", "big", "sample33/bigparlove.c3d", "params"] 0.97 (5%) 1.02 (1%) ❌
["read", "mips-int", "sample01", "full"] 0.93 (5%) ✅ 0.79 (1%) ✅
["read", "mips-int", "sample01", "params"] 1.03 (5%) 1.19 (1%) ❌
["read", "mips-int", "sample02", "full"] 0.97 (5%) 0.88 (1%) ✅
["read", "mips-int", "sample02", "params"] 1.03 (5%) 1.19 (1%) ❌
["read", "mips-real", "sample01", "full"] 0.90 (5%) ✅ 0.79 (1%) ✅
["read", "mips-real", "sample01", "params"] 1.03 (5%) 1.19 (1%) ❌
["read", "mips-real", "sample02", "full"] 1.02 (5%) 0.88 (1%) ✅
["read", "mips-real", "sample02", "params"] 1.05 (5%) ❌ 1.19 (1%) ❌
["read", "pc-int", "sample01", "full"] 0.89 (5%) ✅ 0.79 (1%) ✅
["read", "pc-int", "sample01", "params"] 1.01 (5%) 1.18 (1%) ❌
["read", "pc-int", "sample02", "full"] 0.95 (5%) 0.88 (1%) ✅
["read", "pc-int", "sample02", "params"] 1.01 (5%) 1.18 (1%) ❌
["read", "pc-real", "sample01", "full"] 0.92 (5%) ✅ 0.79 (1%) ✅
["read", "pc-real", "sample01", "params"] 1.03 (5%) 1.18 (1%) ❌
["read", "pc-real", "sample02", "full"] 0.97 (5%) 0.88 (1%) ✅
["read", "pc-real", "sample02", "params"] 1.06 (5%) ❌ 1.18 (1%) ❌
["read", "vax-int", "sample01", "full"] 0.91 (5%) ✅ 0.79 (1%) ✅
["read", "vax-int", "sample01", "params"] 1.01 (5%) 1.18 (1%) ❌
["read", "vax-int", "sample02", "full"] 0.98 (5%) 0.88 (1%) ✅
["read", "vax-int", "sample02", "params"] 1.04 (5%) 1.18 (1%) ❌
["read", "vax-real", "sample01", "full"] 0.94 (5%) ✅ 0.79 (1%) ✅
["read", "vax-real", "sample01", "params"] 1.03 (5%) 1.18 (1%) ❌
["read", "vax-real", "sample02", "full"] 0.98 (5%) 0.88 (1%) ✅
["read", "vax-real", "sample02", "params"] 1.04 (5%) 1.18 (1%) ❌
["show", "simple"] 1.00 (5%) 1.00 (1%)
["show", "text/plain"] 0.98 (5%) 1.00 (1%)
["write", "mips-int", "sample01/Eb015si.c3d"] 0.05 (5%) ✅ 0.10 (1%) ✅
["write", "mips-int", "sample02/sgi_int.c3d"] 0.07 (5%) ✅ 0.11 (1%) ✅
["write", "mips-real", "sample01/Eb015sr.c3d"] 0.27 (5%) ✅ 0.27 (1%) ✅
["write", "mips-real", "sample02/sgi_real.c3d"] 0.39 (5%) ✅ 0.25 (1%) ✅
["write", "pc-int", "sample01/Eb015pi.c3d"] 0.05 (5%) ✅ 0.10 (1%) ✅
["write", "pc-int", "sample02/pc_int.c3d"] 0.07 (5%) ✅ 0.11 (1%) ✅
["write", "pc-real", "sample01/Eb015pr.c3d"] 0.23 (5%) ✅ 0.27 (1%) ✅
["write", "pc-real", "sample02/pc_real.c3d"] 0.45 (5%) ✅ 0.25 (1%) ✅
["write", "trc"] 1.02 (5%) 1.00 (1%)
["write", "vax-int", "sample01/Eb015vi.c3d"] 0.05 (5%) ✅ 0.10 (1%) ✅
["write", "vax-int", "sample02/dec_int.c3d"] 0.07 (5%) ✅ 0.11 (1%) ✅
["write", "vax-real", "sample01/Eb015vr.c3d"] 0.28 (5%) ✅ 0.27 (1%) ✅
["write", "vax-real", "sample02/dec_real.c3d"] 0.37 (5%) ✅ 0.25 (1%) ✅

@halleysfifthinc halleysfifthinc merged commit 9ecc884 into master Aug 14, 2024
3 checks passed
@halleysfifthinc halleysfifthinc deleted the performance branch August 14, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant