Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/guides 2.1 tag helpers #219

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Docs/guides 2.1 tag helpers #219

merged 6 commits into from
Nov 9, 2023

Conversation

swilgosz
Copy link
Member

@swilgosz swilgosz commented Nov 2, 2023

Resolves: #200

@swilgosz swilgosz self-assigned this Nov 2, 2023
@swilgosz swilgosz mentioned this pull request Nov 2, 2023
Open
@swilgosz swilgosz changed the base branch from main to guides-2.1 November 5, 2023 20:00
@timriley timriley mentioned this pull request Nov 6, 2023
Open
jodosha
jodosha reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@jodosha jodosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swilgosz Thank you very much! I left a few inline comments. let's discuss. 🙂

content/v2.1/helpers/overview.md Outdated Show resolved Hide resolved
content/v2.1/helpers/overview.md Outdated Show resolved Hide resolved
content/v2.1/helpers/overview.md Outdated
end
```

## link_to helper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swilgosz What's your idea for organizing all the helpers' documentation? All in here or separated docs?

Copy link
Member Author

@swilgosz swilgosz Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought they'll fit in in a single document of overview, but after working on form_for, that's not gonna happen for sure.

However, methods like: link_to, are still parts of tag helper, so I think they should be kept together

@swilgosz swilgosz requested a review from jodosha November 7, 2023 00:30
jodosha
jodosha approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@jodosha jodosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swilgosz Thank you!

content/v2.1/helpers/tag_helper.md Outdated Show resolved Hide resolved
content/v2.1/helpers/tag_helper.md Outdated Show resolved Hide resolved
@jodosha jodosha merged commit dd0d37a into guides-2.1 Nov 9, 2023
@jodosha jodosha deleted the docs/guides-2.1-tag-helpers branch November 9, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodosha jodosha jodosha approved these changes

@timriley timriley Awaiting requested review from timriley

Assignees

@swilgosz swilgosz

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helpers: tag helpers
2 participants
@swilgosz @jodosha