Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable window decorations #1848

Open
hannobraun opened this issue May 30, 2023 · 0 comments
Open

Re-enable window decorations #1848

hannobraun opened this issue May 30, 2023 · 0 comments
Labels
topic: display Displaying Fornjot models type: bug Something isn't working

Comments

@hannobraun
Copy link
Owner

hannobraun commented May 30, 2023

Window decorations are currently disabled, as per this comment:

// When the window decorations are enabled, I'm seeing the following
// error on Gnome/Wayland, in response to a `ScaleFactorChange`
// event:
// ```
// wl_surface@24: error 2: Buffer size (1940x45) must be an integer multiple of the buffer_scale (2).
// ```
//
// This is happening most of the time. Very rarely, the window will
// open as expected.
//
// I believe that there is a race condition somewhere low in the
// stack, that will cause the buffer size for the window decorations
// to not be updated before the check that produces the above error.
// I failed to track down where this is happening, so I decided to
// deploy this workaround instead of spending more time.
//
// Window decorations should be re-enabled once possible. This is
// being tracked in this issue:
// https://github.com/hannobraun/fornjot/issues/1848
.with_decorations(false)

Once whatever bug that caused this error has been fixed, window decorations should be enabled again.

@hannobraun hannobraun added type: bug Something isn't working topic: display Displaying Fornjot models labels May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: display Displaying Fornjot models type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant