-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot Find Images for this Search Filter #280
Comments
I have been seeing this issue also and would love to know what's behind it. Could it be that Google is prevent you from downloading images if it detects the same IP address being used too quickly? |
I'm not entirely sure. I fixed the issue personally but my code is really inefficient. I am basically running a while loop until till it works.. which means I am calling google images around 3-4 times till I get the URLs I want. Pretty brute force but does the job, would love to see a solution for this issue though. |
I was thinking of doing the same thing but don't want to brute force it. I'm more worried about the root of the issue being Google related. |
After some digging around, I found the issue to be the result of Google updating the response format. Traditionally, each of Google's image result came in the form of:
This library, However, Google will occasionally send the response in a different format, such as this:
This type of response can not be parsed correctly by the library because the library is specifically looking for It's not clear why Google is sending two differently formatted responses. It's also not clear if they will continue to do so in the feature. This particular "bug" could be fixed via pull request but we the community should be mindful of any future changes Google implements to the response format. |
Wow this is an amazing discovery. This makes sense, as to why I am getting so many errors. I think recently google themselves have unrolled a lot of updates, specifically dealing with Google Search and the implementation of a new NLP software called BERT. Maybe they changed a little bit of the code on their end during this which could be causing these changes. |
It seems like they're slowly or partially rolling it out since only some of their responses are different. |
I just started using this library, I never manage to get to download anything. Tried also downloading the chromedriver and specifying it in the attributes.. Nada.. also tried looping till i get downloads, at the third try it always gets hung on "Evaluating", restarting the script seem to get the loop rolling again, till the third try..
|
@pixelicous Could you check if the HTML being returned from google matches either of formats mentioned in: #280 (comment) |
This issue just got worse, my aforementioned method of looping until I get the URLs isn't working now, as the URLs are almost never coming up. This is a huge issue. I'm not sure if it's even being worked or not though :( |
I started to use this lib yesterday and was also unable to download almost anything. Sometimes some keywords worked, but some simple ones like "city" did not succeed. |
@S-Cardenas Could you point me on how to get the html returned using the library? From the other replies it seems I am not the only one 😿 |
the same here. Can't load even a single apple image |
@pixelicous I believe the |
Same here, if i loop it like 100 times then one image sometimes downloads |
Jakub,
Impressive! What was the issue?
…On Wed, Feb 5, 2020 at 4:16 PM Jakub Dobies ***@***.***> wrote:
After all day of pulling my hairs i finally repaired code. I will upload
it after some minor fixes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#280?email_source=notifications&email_token=ADLS6EPSDNZGWN5CZKN56M3RBMUBDA5CNFSM4JILWRVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK5AJWQ#issuecomment-582616282>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLS6EN33N35QT7EQE7632TRBMUBDANCNFSM4JILWRVA>
.
|
Like you said before "start_line = s.find('rg_meta notranslate')" was the problem. I deleted my post cause my solution was to simply search for url by finding string that starts with '"https://" and ends with ".jpg"/".png"... , i said that i will upload it but my deadline is tomorrow and my solutions doesn't work with arguments. I created simplifed version with only keywords and number of images to download. It's a lot of work to add all of it, especially that i started learning python 2 days ago ;'c I will have time after this week so if no one more experienced than me starts to fix it i will try to fully implement parameters etc. |
Dude, let me just say that you're a god if you were able to learn python in 2 days and come up with a fix. And honestly, I just need the image URLs man. I am using this library to simply search Images and gifs and get their URLs. Any help is appreciated. |
PS: Sorry about accidentally closing and reopening issue! |
I will post simplified version tomorrow and full version in a week or two |
#298 Someone else beat me up to it <3 |
Any update on this one ? Because I have the same issue.. :( |
Unfortunately all 10 could not be downloaded because some images were not downloadable. 0 is all we got for this search filter! ((( |
same here ...
result: Unfortunately all 120 could not be downloaded because some images were not downloadable. 0 is all we got for this search filter! Please help... Any other info you want please ask for, dont hesitate |
Is there a solution for this error. |
Use chrome extension guys. All images Download. It can download images over 700 too |
@Divyam10 can you guide me how do I use it in python. |
which extension? send a link |
I thought the problem was solved ;-; I have my simple downloader on github right now, i wanted to post it earlier but i saw someone here that fixed the issue with google_images_download not finding pics. If someone only needs to download or find urls my code is working every time for me, but its veeeerrryyyy simplified and i applied brute force for searching. |
Your new library is sick man, I'm already using it. Thanks a bunch dude. |
Thanks dude, you totally made my day <3 |
your library is veeeeeeeerrrryyyyyy good thank you |
I will update my library this week, i was very busy for last few days. Im adding "high-quality" feature on my bucket list. I think that this wont be a problem i intentionally wanted to skip bigger pics because they took long to download. |
Hello, yes indeed google has changed their response format, i have a script that downloads as well and I got around this issue (in a very ugly and hacky way). |
…itDataCallback() the google page contains info in a script variable `AF_initDataCallback` See the javascript that parses it: https://gist.github.com/FarisHijazi/6c9ba3fb315d0ce9bfa62c10dfa8b2f8 This commit is an implementation to this code.fix-2020-format I have added an iterator that returns rg_meta objects
Total noob developer here. Using cloud IDE (python) and downloaded your library through "pip install simple_image_download" and ran your Test1 file on Python, but nothing shows up. Any idea why? |
Dude you are a God. You saved my project. I was breaking my head over how to scrape google images using cli and found this thread. Can't thank you enough. |
Amazing package. 10/10 👍 |
BROOO !!!! What a package! I spent the whole day for this thing. Found few solutions and the easier one was with bing API. from bing_image_downloader import downloader But your one is a gem! Its so easy and with google images! Thank you! |
try to check on your working directory folder. C:\Users\Nasik\simple_images\ |
Hey,
I recently noticed, google_images_download is failing to download images at random times.
An example of this would be, if I made a loop to download a certain image, and tried to download it 10 times, it would download it most of the time, but fail at random points. For example, iteration 1 of the loop successfully downloads the images, but iteration 9 fails , for no reason, even though the arguments are kept constant.
Could use any and all help on this issue.
The Error I receive is:
Unfortunately all 50 could not be downloaded because some images were not downloadable. 0 is all we got for this search filter!
Thanks,
-vk379
The text was updated successfully, but these errors were encountered: