Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvaluationScriptSuffix modfication is not possible #2802

Open
IRusio opened this issue Oct 22, 2024 · 3 comments
Open

EvaluationScriptSuffix modfication is not possible #2802

IRusio opened this issue Oct 22, 2024 · 3 comments
Labels

Comments

@IRusio
Copy link

IRusio commented Oct 22, 2024

Description

hey @kblok there is still a problem when we talk about stealth mode, as mentioned in #1709 This behaviour is a problem when we try to pass DataDome, as it sends source, so it's quite hard to pass their validation if we can't modify it:
image

In quite old version we were able to modify it via reflection.

Expected behavior:

We are able to modify EvaluationScriptSuffix from Execution Context

Actual behavior:

We can't modify that value, as it is const.

Additional Links:

https://github.com/rebrowser/rebrowser-patches?tab=readme-ov-file#change-default-utility-world-name - this guy prepared a solution on that leak.
https://datadome.co/threat-research/how-new-headless-chrome-the-cdp-signal-are-impacting-bot-detection/ - datadome article how they detect automation

@kblok
Copy link
Member

kblok commented Oct 22, 2024

I think we could implement this https://github.com/puppeteer/puppeteer/pull/10114/files#diff-c7ce55941ba75a4411db2277bb2f54b56869778ae538ee8bb5543f891dd17c3a and make PuppeteerURL.INTERNAL_URL read/write

@kblok
Copy link
Member

kblok commented Oct 22, 2024

I think we could implement this https://github.com/puppeteer/puppeteer/pull/10114/files#diff-c7ce55941ba75a4411db2277bb2f54b56869778ae538ee8bb5543f891dd17c3a and make PuppeteerURL.INTERNAL_URL read/write

@IRusio if you fell comfortable trying to implement this, go for it. If not let me know and I'll add this to my list.

@IRusio
Copy link
Author

IRusio commented Oct 22, 2024

I think we could implement this https://github.com/puppeteer/puppeteer/pull/10114/files#diff-c7ce55941ba75a4411db2277bb2f54b56869778ae538ee8bb5543f891dd17c3a and make PuppeteerURL.INTERNAL_URL read/write

@IRusio if you fell comfortable trying to implement this, go for it. If not let me know and I'll add this to my list.

Sure will try to spend some time today/tomorrow on that ;)

@kblok kblok added the feature label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants