go 1.24 (#4869)

* go 1.24

* Fixed params to Fatal and Msg

* feat(go version) - update the golang version to the 1.24.2

Author: Frozen

.travis.yml

@@ -2,7 +2,7 @@ os: linux
 dist: jammy
 language: go
 go:
-  - 1.22.5
+  - 1.24.2
 go_import_path: github.com/harmony-one/harmony
 cache:
   directories:

Dockerfile

@@ -1,7 +1,7 @@
 FROM ubuntu:22.04
 
 ARG TARGETARCH
-ARG GOLANG_VERSION="1.22.5"
+ARG GOLANG_VERSION="1.24.2"
 
 SHELL ["/bin/bash", "-c"]
 

Makefile

@@ -256,3 +256,4 @@ debug-delete-log:
 	docker volume rm logs_aggregator_loki_data
 	@echo "[WARN] - it needs sudo to remove folder created with loki docker image user"
 	sudo rm -rf test/logs_aggregator/loki
+

README.md

@@ -16,7 +16,7 @@ http://api.hmny.io/
 
 ## Requirements
 
-### **Go 1.22.5**
+### **Go 1.24.2**
 ### **GMP and OpenSSL**
 
 On macOS:

accounts/abi/unpack_test.go

@@ -909,7 +909,7 @@ func TestOOMMaliciousInput(t *testing.T) {
 		}
 		encb, err := hex.DecodeString(test.enc)
 		if err != nil {
-			t.Fatalf("invalid hex: %s" + test.enc)
+			t.Fatalf("invalid hex: %s", test.enc)
 		}
 		_, err = abi.Methods["method"].Outputs.UnpackValues(encb)
 		if err == nil {

api/service/legacysync/downloader/Proto.Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22.5-bullseye
+FROM golang:1.24.2-bullseye
 
 RUN apt update
 RUN apt install -y protobuf-compiler

api/service/stagedstreamsync/stage_heads.go

@@ -83,7 +83,7 @@ func (heads *StageHeads) Exec(ctx context.Context, firstCycle bool, invalidBlock
 			Uint64("currentHeight", currentHeight).
 			Uint64("maxPeersHeight", maxHeight).
 			Uint64("targetHeight", targetHeight).
-			Msgf(WrapStagedSyncMsg("current height is ahead of target height, target height is readjusted to max peers height"))
+			Msg(WrapStagedSyncMsg("current height is ahead of target height, target height is readjusted to max peers height"))
 		targetHeight = maxHeight
 	}
 
@@ -108,7 +108,7 @@ func (heads *StageHeads) Exec(ctx context.Context, firstCycle bool, invalidBlock
 	if err := s.Update(tx, targetHeight); err != nil {
 		heads.configs.logger.Error().
 			Err(err).
-			Msgf(WrapStagedSyncMsg("saving progress for headers stage failed"))
+			Msg(WrapStagedSyncMsg("saving progress for headers stage failed"))
 		return err
 	}
 

api/service/stagedstreamsync/staged_stream_sync.go

@@ -225,7 +225,7 @@ func (sss *StagedStreamSync) RevertTo(revertPoint uint64, invalidBlockNumber uin
 		Interface("invalidBlockHash", invalidBlockHash).
 		Interface("invalidBlockStreamID", invalidBlockStreamID).
 		Uint64("revertPoint", revertPoint).
-		Msgf(WrapStagedSyncMsg("Reverting blocks"))
+		Msg(WrapStagedSyncMsg("Reverting blocks"))
 	sss.revertPoint = &revertPoint
 	if invalidBlockNumber > 0 || invalidBlockHash != (common.Hash{}) {
 		resetBadStreams := !sss.invalidBlock.Active
@@ -286,7 +286,7 @@ func (sss *StagedStreamSync) cleanUp(ctx context.Context, fromStage int, db kv.R
 		if err := sss.pruneStage(ctx, firstCycle, sss.pruningOrder[i], db, tx); err != nil {
 			sss.logger.Error().Err(err).
 				Interface("stage id", sss.pruningOrder[i].ID).
-				Msgf(WrapStagedSyncMsg("stage cleanup failed"))
+				Msg(WrapStagedSyncMsg("stage cleanup failed"))
 			panic(err)
 		}
 	}
@@ -431,7 +431,7 @@ func (sss *StagedStreamSync) Run(ctx context.Context, db kv.RwDB, tx kv.RwTx, fi
 						sss.logger.Error().
 							Err(err).
 							Interface("stage id", sss.revertOrder[j].ID).
-							Msgf(WrapStagedSyncMsg("revert stage failed"))
+							Msg(WrapStagedSyncMsg("revert stage failed"))
 						return err
 					}
 				}
@@ -446,7 +446,7 @@ func (sss *StagedStreamSync) Run(ctx context.Context, db kv.RwDB, tx kv.RwTx, fi
 
 		if stage.Disabled {
 			sss.logger.Trace().
-				Msgf(WrapStagedSyncMsg(fmt.Sprintf("%s disabled. %s", stage.ID, stage.DisabledDescription)))
+				Msg(WrapStagedSyncMsg(fmt.Sprintf("%s disabled. %s", stage.ID, stage.DisabledDescription)))
 
 			sss.NextStage()
 			continue
@@ -461,7 +461,7 @@ func (sss *StagedStreamSync) Run(ctx context.Context, db kv.RwDB, tx kv.RwTx, fi
 			sss.logger.Error().
 				Err(err).
 				Interface("stage id", stage.ID).
-				Msgf(WrapStagedSyncMsg("stage failed"))
+				Msg(WrapStagedSyncMsg("stage failed"))
 			return err
 		}
 		sss.NextStage()
@@ -470,7 +470,7 @@ func (sss *StagedStreamSync) Run(ctx context.Context, db kv.RwDB, tx kv.RwTx, fi
 	if err := sss.cleanUp(ctx, 0, db, tx, firstCycle); err != nil {
 		sss.logger.Error().
 			Err(err).
-			Msgf(WrapStagedSyncMsg("stages cleanup failed"))
+			Msg(WrapStagedSyncMsg("stages cleanup failed"))
 		return err
 	}
 	if err := sss.SetCurrentStage(sss.stages[0].ID); err != nil {
@@ -564,7 +564,7 @@ func printLogs(tx kv.RwTx, timings []Timing) error {
 	}
 	if len(logCtx) > 0 {
 		timingLog := fmt.Sprintf("Timings (slower than 50ms) %v", logCtx)
-		utils.Logger().Info().Msgf(WrapStagedSyncMsg(timingLog))
+		utils.Logger().Info().Msg(WrapStagedSyncMsg(timingLog))
 	}
 
 	if tx == nil {
@@ -582,7 +582,7 @@ func printLogs(tx kv.RwTx, timings []Timing) error {
 			bucketSizes = append(bucketSizes, bucket, ByteCount(sz))
 		}
 		utils.Logger().Info().
-			Msgf(WrapStagedSyncMsg(fmt.Sprintf("Tables %v", bucketSizes...)))
+			Msg(WrapStagedSyncMsg(fmt.Sprintf("Tables %v", bucketSizes...)))
 	}
 	tx.CollectMetrics()
 	return nil
@@ -599,15 +599,15 @@ func (sss *StagedStreamSync) runStage(ctx context.Context, stage *Stage, db kv.R
 		sss.logger.Error().
 			Err(err).
 			Interface("stage id", stage.ID).
-			Msgf(WrapStagedSyncMsg("stage failed"))
+			Msg(WrapStagedSyncMsg("stage failed"))
 		return fmt.Errorf("[%s] %w", sss.LogPrefix(), err)
 	}
 
 	took := time.Since(start)
 	if took > 60*time.Second {
 		logPrefix := sss.LogPrefix()
 		sss.logger.Info().
-			Msgf(WrapStagedSyncMsg(fmt.Sprintf("%s:  DONE in %d", logPrefix, took)))
+			Msg(WrapStagedSyncMsg(fmt.Sprintf("%s:  DONE in %d", logPrefix, took)))
 
 	}
 	sss.timings = append(sss.timings, Timing{stage: stage.ID, took: took})
@@ -641,7 +641,7 @@ func (sss *StagedStreamSync) revertStage(ctx context.Context, firstCycle bool, s
 	if took > 60*time.Second {
 		logPrefix := sss.LogPrefix()
 		sss.logger.Info().
-			Msgf(WrapStagedSyncMsg(fmt.Sprintf("%s: Revert done in %d", logPrefix, took)))
+			Msg(WrapStagedSyncMsg(fmt.Sprintf("%s: Revert done in %d", logPrefix, took)))
 	}
 	sss.timings = append(sss.timings, Timing{isRevert: true, stage: stage.ID, took: took})
 	return nil
@@ -673,7 +673,7 @@ func (sss *StagedStreamSync) pruneStage(ctx context.Context, firstCycle bool, st
 	if took > 60*time.Second {
 		logPrefix := sss.LogPrefix()
 		sss.logger.Info().
-			Msgf(WrapStagedSyncMsg(fmt.Sprintf("%s: CleanUp done in %d", logPrefix, took)))
+			Msg(WrapStagedSyncMsg(fmt.Sprintf("%s: CleanUp done in %d", logPrefix, took)))
 	}
 	sss.timings = append(sss.timings, Timing{isCleanUp: true, stage: stage.ID, took: took})
 	return nil

api/service/stagedstreamsync/syncing.go

@@ -450,7 +450,7 @@ func (s *StagedStreamSync) doSyncCycle(ctx context.Context) (int, error) {
 			Bool("isBeaconShard", s.isBeaconShard).
 			Uint32("shard", s.bc.ShardID()).
 			Uint64("currentHeight", startHead).
-			Msgf(WrapStagedSyncMsg("sync cycle failed"))
+			Msg(WrapStagedSyncMsg("sync cycle failed"))
 		return totalInserted, err
 	}
 

consensus/consensus.go

@@ -256,7 +256,7 @@ func (consensus *Consensus) getLeaderPrivateKey(leaderKey *bls_core.PublicKey) (
 			return &consensus.priKey[i], nil
 		}
 	}
-	return nil, errors.Wrapf(errLeaderPriKeyNotFound, leaderKey.SerializeToHexStr())
+	return nil, errors.Wrap(errLeaderPriKeyNotFound, leaderKey.SerializeToHexStr())
 }
 
 // getConsensusLeaderPrivateKey returns consensus leader private key if node is the leader

core/evm_test.go

@@ -448,7 +448,7 @@ func TestWriteCapablePrecompilesIntegration(t *testing.T) {
 	expectedError := errors.New("abi: cannot marshal in to go type: length insufficient 31 require 32")
 	if err != nil {
 		if err.Error() != expectedError.Error() {
-			t.Errorf(fmt.Sprintf("Got error %v in evm.Call but expected %v", err, expectedError))
+			t.Error(fmt.Sprintf("Got error %v in evm.Call but expected %v", err, expectedError))
 		}
 	}
 
@@ -460,7 +460,7 @@ func TestWriteCapablePrecompilesIntegration(t *testing.T) {
 		[]byte{},
 		math.MaxUint64, new(big.Int))
 	if err != nil {
-		t.Errorf(fmt.Sprintf("Got error %v in evm.Call", err))
+		t.Error(fmt.Sprintf("Got error %v in evm.Call", err))
 	}
 
 	// now without staking precompile
@@ -472,6 +472,6 @@ func TestWriteCapablePrecompilesIntegration(t *testing.T) {
 		[]byte{},
 		math.MaxUint64, new(big.Int))
 	if err != nil {
-		t.Errorf(fmt.Sprintf("Got error %v in evm.Call", err))
+		t.Error(fmt.Sprintf("Got error %v in evm.Call", err))
 	}
 }

core/staking_verifier.go

@@ -90,7 +90,7 @@ func VerifyAndCreateValidatorFromMsg(
 		return nil, errNegativeAmount
 	}
 	if stateDB.IsValidator(msg.ValidatorAddress) {
-		return nil, errors.Wrapf(
+		return nil, errors.Wrap(
 			errValidatorExist, common2.MustAddressToBech32(msg.ValidatorAddress),
 		)
 	}

core/state_transition_test.go

@@ -79,9 +79,9 @@ func testApplyStakingMessage(test applyStakingMessageTest, t *testing.T) {
 		_, err := ApplyStakingMessage(vmenv, msg, gp)
 		if err != nil {
 			if test.expectedError == nil {
-				t.Errorf(fmt.Sprintf("Got error %v but expected none", err))
+				t.Error(fmt.Sprintf("Got error %v but expected none", err))
 			} else if test.expectedError.Error() != err.Error() {
-				t.Errorf(fmt.Sprintf("Got error %v, but expected %v", err, test.expectedError))
+				t.Error(fmt.Sprintf("Got error %v, but expected %v", err, test.expectedError))
 			}
 		}
 	})

go.mod

@@ -1,8 +1,8 @@
 module github.com/harmony-one/harmony
 
-go 1.22.0
+go 1.24.0
 
-toolchain go1.22.5
+toolchain go1.24.2
 
 require (
 	github.com/RoaringBitmap/roaring v1.2.3
@@ -69,7 +69,6 @@ require (
 )
 
 require (
-	github.com/c2h5oh/datasize v0.0.0-20220606134207-859f65c6625b
 	github.com/dustin/go-humanize v1.0.0
 	github.com/hashicorp/golang-lru/v2 v2.0.7
 	github.com/holiman/bloomfilter/v2 v2.0.3
@@ -80,6 +79,7 @@ require (
 	github.com/ledgerwatch/log/v3 v3.8.0
 	github.com/libp2p/go-libp2p-mplex v0.9.0
 	github.com/multiformats/go-base32 v0.1.0
+	github.com/multiformats/go-multihash v0.2.3
 	github.com/olekukonko/tablewriter v0.0.5
 	github.com/pbnjay/memory v0.0.0-20210728143218-7b4eea64cf58
 	golang.org/x/exp v0.0.0-20250128182459-e0ece0dbea4c
@@ -99,6 +99,7 @@ require (
 	github.com/bombsimon/wsl/v2 v2.0.0 // indirect
 	github.com/btcsuite/btcd/btcec/v2 v2.3.2 // indirect
 	github.com/btcsuite/btcd/chaincfg/chainhash v1.0.2 // indirect
+	github.com/c2h5oh/datasize v0.0.0-20220606134207-859f65c6625b // indirect
 	github.com/cespare/xxhash v1.1.0 // indirect
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
 	github.com/cockroachdb/errors v1.11.1 // indirect
@@ -216,7 +217,6 @@ require (
 	github.com/multiformats/go-multiaddr-fmt v0.1.0 // indirect
 	github.com/multiformats/go-multibase v0.2.0 // indirect
 	github.com/multiformats/go-multicodec v0.9.0 // indirect
-	github.com/multiformats/go-multihash v0.2.3 // indirect
 	github.com/multiformats/go-multistream v0.6.0 // indirect
 	github.com/multiformats/go-varint v0.0.7 // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect

internal/chain/reward.go

@@ -192,7 +192,7 @@ func accumulateRewardsAndCountSigsBeforeStaking(
 			Int64("block-reward", stakingReward.PreStakedBlocks.Int64()).
 			Int64("total-amount-paid-out", totalAmount.Int64()).
 			Msg("Total paid out was not equal to block-reward")
-		return numeric.ZeroDec(), nil, errors.Wrapf(
+		return numeric.ZeroDec(), nil, errors.Wrap(
 			network.ErrPayoutNotEqualBlockReward, "payout "+totalAmount.String(),
 		)
 	}

rosetta/infra/Dockerfile

@@ -1,5 +1,5 @@
 # Build
-FROM golang:1.22.5 AS build
+FROM golang:1.24.2 AS build
 
 RUN apt update -y && \
     apt install libgmp-dev libssl-dev git -y && \

rosetta/services/account_test.go

@@ -14,16 +14,16 @@ import (
 func TestNewAccountIdentifier(t *testing.T) {
 	key, err := crypto.GenerateKey()
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 	addr := crypto.PubkeyToAddress(key.PublicKey)
 	b32Addr, err := internalCommon.AddressToBech32(addr)
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 	metadata, err := types.MarshalMap(AccountMetadata{Address: addr.String()})
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 
 	referenceAccID := &types.AccountIdentifier{
@@ -42,12 +42,12 @@ func TestNewAccountIdentifier(t *testing.T) {
 func TestGetAddress(t *testing.T) {
 	key, err := crypto.GenerateKey()
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 	addr := crypto.PubkeyToAddress(key.PublicKey)
 	b32Addr, err := internalCommon.AddressToBech32(addr)
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 	testAccID := &types.AccountIdentifier{
 		Address: b32Addr,

rosetta/services/construction_create_test.go

@@ -70,7 +70,7 @@ func TestUnpackWrappedTransactionFromString(t *testing.T) {
 	// Test staking transactions
 	receiverKey, err := crypto.GenerateKey()
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 	stx, err := helpers.CreateTestStakingTransaction(func() (stakingTypes.Directive, interface{}) {
 		return stakingTypes.DirectiveDelegate, stakingTypes.Delegate{

rosetta/services/network_test.go

@@ -170,7 +170,7 @@ func TestGetPeersFromNodePeerInfo(t *testing.T) {
 		}
 
 		if err := checkPeerID(p, refTopics); err != nil {
-			t.Errorf(err.Error())
+			t.Error(err.Error())
 		}
 	}
 

rosetta/services/tx_format_test.go

@@ -40,11 +40,11 @@ func TestFormatTransactionIntegration(t *testing.T) {
 	gasUsed := uint64(1e5)
 	senderKey, err := crypto.GenerateKey()
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 	receiverKey, err := crypto.GenerateKey()
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 
 	testFormatStakingTransaction(t, gasLimit, gasUsed, senderKey, receiverKey)