"Go to references" on a variable that a `Using` overwrites includes references to the `Using`'s struct's field

[harrisont]

I'm unsure if this is actually undesired behavior or not - I'll need to ponder it.

Repro

"Go to references" on the .A of the .A = 3 statement in:

.A = 3
Print( 'Before $A$' )

.MyStruct = [
    .A = 1
]

Using( .MyStruct )
Print( 'After $A$' )

Expected

3 references:

• .A = 3
• Print( 'Before $A$' )
• Using( .MyStruct )

Actual

5 references:

• .A = 1
• .A = 3
• Print( 'Before $A$' )
• Using( .MyStruct )
• Print( 'After $A$' )

[harrisont]

Diagram of the current references, to help visualize them:

flowchart TD
    ExistingVarDefinition[".A = 3 (defines .A)"] ~~~
    ExistingVarUsage["Print( 'Before $A$' )"] ~~~
    StructFieldDefinition[".A = 1"] ~~~
    Using["Using( .MyStruct )"] ~~~
    VarFromUsingUsage["Print( 'After $A$' )"]

    ExistingVarUsage -->|reads| ExistingVarDefinition
    StructFieldDefinition -->|references| ExistingVarDefinition
    Using -->|sets to 1| ExistingVarDefinition
    VarFromUsingUsage -->|reads| ExistingVarDefinition

Loading