Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for remove/remove all signatures #1049

Open
jbair06 opened this issue Sep 3, 2024 · 1 comment
Open

Add functions for remove/remove all signatures #1049

jbair06 opened this issue Sep 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jbair06
Copy link
Member

jbair06 commented Sep 3, 2024

Problem

Issued copied from JS SDK: hashgraph/hedera-sdk-js#2491

Once a signature has been added via addSignature, there is no convenience method to remove the signature.

Removing signatures is helpful when a transaction has a signing account that has a large keylist with many thresholds. If all signatures added to the transaction result in a transaction too large to submit, then only the minimum number of signatures required to make the transaction valid should be added to the transaction.

Also, if a signature is added, the owner of the key might decide to revoke the signature. Without recreating the transaction and re adding all the signatures, this is not possible.

Solution

  • Add removeSignature(publicKey/signature) method
  • Add removeAllSignatures() method

These two convenience methods will be helpful to remove signatures as needed.

Review the solution in the JS SDK: hashgraph/hedera-sdk-js#2491

Alternatives

No response

@jbair06 jbair06 added the enhancement New feature or request label Sep 3, 2024
@SimiHunjan SimiHunjan added this to the v2.46.0 milestone Sep 4, 2024
@SimiHunjan SimiHunjan modified the milestones: v2.46.0, v2.47.0 Sep 17, 2024
@0xivanov
Copy link
Contributor

0xivanov commented Sep 30, 2024

This feature would need to expose an API in all transactions that we have, and all transactions in the future.
Since this functionality is not urgent now, we would like to start the implementation after refactoring the current architecture.

@SimiHunjan SimiHunjan removed this from the v2.47.0 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants