Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements of and documentation of the Gradle build #1794

Closed
jjohannes opened this issue Apr 30, 2024 · 1 comment · Fixed by #2179
Closed

Improvements of and documentation of the Gradle build #1794

jjohannes opened this issue Apr 30, 2024 · 1 comment · Fixed by #2179
Assignees
Labels
enhancement New feature or request

Comments

@jjohannes
Copy link
Contributor

jjohannes commented Apr 30, 2024

This issue is a follow-up for the work done here: #1732
Each task should be converted to an issue and addressed separately. Tasks are aligned in a priority order.

### Tasks
- [ ] https://github.com/hashgraph/hedera-sdk-java/issues/1885
- [ ] https://github.com/hashgraph/hedera-sdk-java/issues/1898
- [ ] https://github.com/hashgraph/hedera-sdk-java/issues/1894
- [x] Introduce Guava fix, which should be in plugin in the future
- [x] Get rid of `mergeJar("com.google.code.findbugs:jsr305")`
- [x] Adjust the code style rules and tools to what its done in _hedera-services_ (e.g. remove sonar, introduce spotless, decide if we want to keep error prone etc.)
- [x] Revisit gradle setup in `tck` project
- [ ] https://github.com/hashgraph/hedera-sdk-java/issues/1896
- [x] Add more docs for the Gradle build (`.kts` files, code comments)
- [x] Resolve duplication in constraints publishing (right now there is some duplication)
- [x] Add PR Check for the Android Example (that it builds)
- [x] Add more docs for the Gradle build (`.md` files, in particular for adding/modifying dependencies)
- [x] Review what SDK dependencies should be transitive: https://github.com/hashgraph/hedera-sdk-java/pull/1732#discussion_r1603375896 --> moved to https://github.com/hashgraph/hedera-sdk-java/issues/2180
- [ ] Revisit `Taskfile.yml` (maybe make it as gradle tasks)
@jjohannes
Copy link
Contributor Author

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants