Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update directory for gradle in dependabot #1922

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

isavov
Copy link
Contributor

@isavov isavov commented Jul 25, 2024

Description:
This PR updates the dependabot config to handle the updated gradle setup

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@isavov isavov added the github_actions Pull requests that update GitHub Actions code label Jul 25, 2024
@isavov isavov self-assigned this Jul 25, 2024
@isavov isavov requested review from a team as code owners July 25, 2024 10:36
@thenswan
Copy link
Contributor

Hey @jjohannes @rbarkerSL,

This change was made because after #1732 I see that dependabot doesn’t open new PRs for sdk dependencies specifically, as it did before.

Can you please help reviewing this PR? 🙏🏻

@thenswan
Copy link
Contributor

thenswan commented Jul 25, 2024

I think we also need to keep in mind this (duplication): #1911 (review)

Copy link

sonarcloud bot commented Jul 25, 2024

Copy link
Contributor

@jjohannes jjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not fully understand why Dependabot does not inspect the file in sdk-dependency-versions when we do /. But yes, this should fix it.

@isavov isavov merged commit b74b846 into main Aug 19, 2024
8 checks passed
@isavov isavov deleted the chore/update-dependabot-settings branch August 19, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants