Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E: AccountAllowanceDeleteTransaction #90

Open
11 tasks
Tracked by #85
SimiHunjan opened this issue May 24, 2023 · 3 comments
Open
11 tasks
Tracked by #85

Add E2E: AccountAllowanceDeleteTransaction #90

SimiHunjan opened this issue May 24, 2023 · 3 comments
Assignees
Labels
good first issue Issues which are ideal for a first time or new project contributor. hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution.

Comments

@SimiHunjan
Copy link
Contributor

SimiHunjan commented May 24, 2023

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to Hedera or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hedera.

👾 Description of the issue

Testing the proper functionality of token allowances, particularly for NFTs in Hedera, requires robust integration tests. These tests ensure that once an allowance is deleted, further transfers fail as expected, and verify the system’s behavior when specific serials or all serials are removed from allowances.

Solution

The following are integration test cases for managing and verifying the behavior of token allowances in the Hedera Rust SDK. These tests cover removing allowances for specific NFTs, ensuring transfers fail after deletion, and testing partial or full allowance removal. Reference from Rust: e2e/account/allowance_delete

Implementation

  1. Create an NFT collection
  2. Approve allowances for the NFTs
  3. Delete allowances

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.

  • Claim this issue: Comment below that you are interested in working on the issue
  • Wait for assignment: A community member with the given rights will add you as an assignee of the issue
  • Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
  • Solve the issue in your branch.
  • Commit your changes: Here, it is needed to add sign-off information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md
  • Start a Pull Request (PR): We have a pattern for naming pull requests that a GitHub Action checks. We use that pattern to support the creation of automatic release notes.
  • Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the Hedera developer community for support.
  • Wait for reviews: Members of the Hedera developer community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
  • You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of the Hedera community as an open-source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional Information

If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

@SimiHunjan SimiHunjan mentioned this issue May 24, 2023
@SimiHunjan SimiHunjan added this to the v0.21.0 milestone May 24, 2023
@izik1
Copy link
Contributor

izik1 commented Jun 12, 2023

@izik1 izik1 removed this from the v0.21.0 milestone Jun 12, 2023
@RickyLB RickyLB added good first issue candidate Issues that can become a good first issue but need more description/context. labels Sep 12, 2024
@hendrikebbers hendrikebbers added good first issue Issues which are ideal for a first time or new project contributor. hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. and removed good first issue candidate Issues that can become a good first issue but need more description/context. labels Oct 17, 2024
@b-l-u-e
Copy link
Contributor

b-l-u-e commented Oct 25, 2024

Please assign me to this issue @hendrikebbers

@b-l-u-e
Copy link
Contributor

b-l-u-e commented Nov 7, 2024

@hendrikebbers

@RickyLB RickyLB assigned RickyLB and b-l-u-e and unassigned RickyLB Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues which are ideal for a first time or new project contributor. hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution.
Projects
None yet
Development

No branches or pull requests

5 participants