Add a "json" type for set

[dannystaple]

Description

The set command https://registry.terraform.io/providers/hashicorp/helm/latest/docs/resources/release#set-6 will not handle JSON or some characters very well, resulting in parser issues. E.g. error parsing index: strconv.Atoi if there are square brackets anywhere.

The literal command can be used, but is a very blunt instrument, overriding whole structures.

However, a "set-json" would mean the keys can override nested structure elements, and with json. Json would not have it's "runes" interpreted as "stop" runes by the parser after the first = sign.

Potential Terraform Configuration

Within a resource "helm_release" "chartname":

set =   [
  {
    name = "somePod.annotations.interesting\\.annotation\\.for\\.some\\.operator",
    value = jsonencode("thing with runes parser might think are stops"),
    type="json"
  }
]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[dannystaple]

My guess here would be that this needs:

• A case for valueType 'json' is added to applySetValue in helm/data_helm_template.go calling strvals.ParseJSON.
• A case for valueType 'json' is added to getValue in helm/resource_helm_release.go calling strvals.ParseJSON.
• resource tests - although TestGetValuesString is commented out in helm/resource_helm_release_test.go.
• data tests - although I don't see a test specifying a type for set in helm/data_helm_template_test.go.
• Documentation at docs/resources/release.md#nested-schema-for-set - although this does not specify the values for type.
• Documentation at docs/data-sources/template.md#nestedblock--set - although this also does not specify the values for type.