-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defaults: add support for a token file environment variable #291
defaults: add support for a token file environment variable #291
Conversation
3c6bb42
to
b5cbfc7
Compare
HI @dhuckins sorry for ping you, I saw that you made a PR recently and I don't know who this project's active maintainers are. Could you give it a look, or if that is not possible, tell me what I could do instead |
ping @AnPucel |
@matiasbertani seems good to me! do you mind adding a test please? |
b5cbfc7
to
ae8ca82
Compare
ae8ca82
to
e29f9dd
Compare
e29f9dd
to
4d9d4f2
Compare
@dhuckins I'm sorry for the long delay. I've added unit test and also I've refactored the previous code to improve it. Let me know if you need anything else |
friendly ping @dhuckins 😄 |
Is there anything left for me to do to track this? @dhuckins |
Ping @dhuckins |
@dhuckins Is there anything I can do to move forward with the merge of this PR? |
desperate ping @dhuckins |
hey, sorry @matiasbertani there's been a shakeup here and not watching this repo any more |
Right now, using the Agent Sidecar Injector with an annotation to share the token with a ruby app container, it always writes the token at the path
/vault/secrets/token
By default, the client only looks for the token at
"#{ENV["HOME"]}/.vault-token"
Solution
add support for a new environment variable
VAULT_TOKEN_FILE
to look for the token if it is defined