Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaults: add support for a token file environment variable #291

Merged
merged 1 commit into from
May 20, 2024

Conversation

matiasbertani
Copy link
Contributor

Right now, using the Agent Sidecar Injector with an annotation to share the token with a ruby app container, it always writes the token at the path /vault/secrets/token

By default, the client only looks for the token at "#{ENV["HOME"]}/.vault-token"

Solution

add support for a new environment variable VAULT_TOKEN_FILE to look for the token if it is defined

@matiasbertani matiasbertani requested a review from a team May 17, 2023 15:10
@hashicorp-cla
Copy link

hashicorp-cla commented May 17, 2023

CLA assistant check
All committers have signed the CLA.

@matiasbertani matiasbertani changed the title defaults: add support for token_file env defaults: add support for a token file enviroment variable May 18, 2023
@matiasbertani matiasbertani changed the title defaults: add support for a token file enviroment variable defaults: add support for a token file environment variable May 18, 2023
@matiasbertani
Copy link
Contributor Author

HI @dhuckins sorry for ping you, I saw that you made a PR recently and I don't know who this project's active maintainers are. Could you give it a look, or if that is not possible, tell me what I could do instead

@matiasbertani
Copy link
Contributor Author

ping @AnPucel

@dhuckins
Copy link
Contributor

dhuckins commented Jun 5, 2023

@matiasbertani seems good to me! do you mind adding a test please?

@matiasbertani
Copy link
Contributor Author

@dhuckins I'm sorry for the long delay. I've added unit test and also I've refactored the previous code to improve it. Let me know if you need anything else

@matiasbertani
Copy link
Contributor Author

friendly ping @dhuckins 😄

@matiasbertani
Copy link
Contributor Author

Is there anything left for me to do to track this? @dhuckins

@matiasbertani
Copy link
Contributor Author

Ping @dhuckins

@matiasbertani
Copy link
Contributor Author

@dhuckins Is there anything I can do to move forward with the merge of this PR?

@matiasbertani
Copy link
Contributor Author

desperate ping @dhuckins

@dhuckins
Copy link
Contributor

dhuckins commented May 20, 2024

hey, sorry @matiasbertani there's been a shakeup here and not watching this repo any more

@dhuckins dhuckins merged commit ad23081 into hashicorp:master May 20, 2024
1 check passed
@matiasbertani matiasbertani deleted the support-disk-token-as-env branch June 13, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants