Skip to content

Commit 4c01fe1

Browse files
kubeclaude
andcommitted
FE-518: Fix PR review findings for refractive
- Bump Storybook from 10.2.13 to 10.2.19 for Vite 8 compatibility - Update ds-components/switch.tsx to use renamed `lip` export Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
1 parent 43d5d59 commit 4c01fe1

File tree

3 files changed

+6
-122
lines changed

3 files changed

+6
-122
lines changed

libs/@hashintel/ds-components/src/components/switch.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Switch as BaseSwitch } from "@ark-ui/react/switch";
22
import { css } from "@hashintel/ds-helpers/css";
3-
import { LIP, refractive } from "@hashintel/refractive";
3+
import { lip, refractive } from "@hashintel/refractive";
44

55
// Layout constants
66
const SLIDER_HEIGHT = 20;
@@ -104,7 +104,7 @@ export const Switch: React.FC<SwitchProps> = ({
104104
refraction={{
105105
radius: THUMB_RADIUS,
106106
bezelWidth: THUMB_RADIUS * 0.42,
107-
bezelHeightFn: LIP,
107+
bezelHeightFn: lip,
108108
glassThickness: 12,
109109
specularOpacity: 0.5,
110110
}}

libs/@hashintel/refractive/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
},
3333
"devDependencies": {
3434
"@rolldown/plugin-babel": "0.2.1",
35-
"@storybook/react-vite": "10.2.13",
35+
"@storybook/react-vite": "10.2.19",
3636
"@types/react": "19.2.7",
3737
"@types/react-dom": "19.2.3",
3838
"@typescript/native-preview": "7.0.0-dev.20260315.1",
@@ -41,7 +41,7 @@
4141
"oxlint": "1.55.0",
4242
"oxlint-tsgolint": "0.17.0",
4343
"rolldown-plugin-dts": "0.22.5",
44-
"storybook": "10.2.13",
44+
"storybook": "10.2.19",
4545
"vite": "8.0.0"
4646
},
4747
"peerDependencies": {

yarn.lock

Lines changed: 2 additions & 118 deletions
Original file line numberDiff line numberDiff line change
@@ -8024,7 +8024,7 @@ __metadata:
80248024
resolution: "@hashintel/refractive@workspace:libs/@hashintel/refractive"
80258025
dependencies:
80268026
"@rolldown/plugin-babel": "npm:0.2.1"
8027-
"@storybook/react-vite": "npm:10.2.13"
8027+
"@storybook/react-vite": "npm:10.2.19"
80288028
"@types/react": "npm:19.2.7"
80298029
"@types/react-dom": "npm:19.2.3"
80308030
"@typescript/native-preview": "npm:7.0.0-dev.20260315.1"
@@ -8033,7 +8033,7 @@ __metadata:
80338033
oxlint: "npm:1.55.0"
80348034
oxlint-tsgolint: "npm:0.17.0"
80358035
rolldown-plugin-dts: "npm:0.22.5"
8036-
storybook: "npm:10.2.13"
8036+
storybook: "npm:10.2.19"
80378037
vite: "npm:8.0.0"
80388038
peerDependencies:
80398039
react: ^19.0.0
@@ -16931,19 +16931,6 @@ __metadata:
1693116931
languageName: node
1693216932
linkType: hard
1693316933

16934-
"@storybook/builder-vite@npm:10.2.13":
16935-
version: 10.2.13
16936-
resolution: "@storybook/builder-vite@npm:10.2.13"
16937-
dependencies:
16938-
"@storybook/csf-plugin": "npm:10.2.13"
16939-
ts-dedent: "npm:^2.0.0"
16940-
peerDependencies:
16941-
storybook: ^10.2.13
16942-
vite: ^5.0.0 || ^6.0.0 || ^7.0.0
16943-
checksum: 10c0/0510e57d86ea7f81ba49ffd3643645e94e082f18544bd506bdcd800c003414707d3572c204704dfe429a3e02fa1bdf6111d309abbd20a294200cb9ba87ea7972
16944-
languageName: node
16945-
linkType: hard
16946-
1694716934
"@storybook/builder-vite@npm:10.2.19":
1694816935
version: 10.2.19
1694916936
resolution: "@storybook/builder-vite@npm:10.2.19"
@@ -16970,30 +16957,6 @@ __metadata:
1697016957
languageName: node
1697116958
linkType: hard
1697216959

16973-
"@storybook/csf-plugin@npm:10.2.13":
16974-
version: 10.2.13
16975-
resolution: "@storybook/csf-plugin@npm:10.2.13"
16976-
dependencies:
16977-
unplugin: "npm:^2.3.5"
16978-
peerDependencies:
16979-
esbuild: "*"
16980-
rollup: "*"
16981-
storybook: ^10.2.13
16982-
vite: "*"
16983-
webpack: "*"
16984-
peerDependenciesMeta:
16985-
esbuild:
16986-
optional: true
16987-
rollup:
16988-
optional: true
16989-
vite:
16990-
optional: true
16991-
webpack:
16992-
optional: true
16993-
checksum: 10c0/e799f9630cfc50ef3c85304f74ffb54372e57f291112d7459de99f4fa21da814374807ac6af312141af11f5e0c746963735e1e41566dd62d0ac7eeb8cf0053ba
16994-
languageName: node
16995-
linkType: hard
16996-
1699716960
"@storybook/csf-plugin@npm:10.2.19":
1699816961
version: 10.2.19
1699916962
resolution: "@storybook/csf-plugin@npm:10.2.19"
@@ -17065,17 +17028,6 @@ __metadata:
1706517028
languageName: node
1706617029
linkType: hard
1706717030

17068-
"@storybook/react-dom-shim@npm:10.2.13":
17069-
version: 10.2.13
17070-
resolution: "@storybook/react-dom-shim@npm:10.2.13"
17071-
peerDependencies:
17072-
react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17073-
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17074-
storybook: ^10.2.13
17075-
checksum: 10c0/78c9788748aae81541727e3cfe32dc1c14aef10af0a5c979d307ec1910d15d5105341ce1c2d5d27ae9ad40dec6de6c0c9c85dfbf12f90c14da678eee5581a3cf
17076-
languageName: node
17077-
linkType: hard
17078-
1707917031
"@storybook/react-dom-shim@npm:10.2.19":
1708017032
version: 10.2.19
1708117033
resolution: "@storybook/react-dom-shim@npm:10.2.19"
@@ -17098,28 +17050,6 @@ __metadata:
1709817050
languageName: node
1709917051
linkType: hard
1710017052

17101-
"@storybook/react-vite@npm:10.2.13":
17102-
version: 10.2.13
17103-
resolution: "@storybook/react-vite@npm:10.2.13"
17104-
dependencies:
17105-
"@joshwooding/vite-plugin-react-docgen-typescript": "npm:^0.6.4"
17106-
"@rollup/pluginutils": "npm:^5.0.2"
17107-
"@storybook/builder-vite": "npm:10.2.13"
17108-
"@storybook/react": "npm:10.2.13"
17109-
empathic: "npm:^2.0.0"
17110-
magic-string: "npm:^0.30.0"
17111-
react-docgen: "npm:^8.0.0"
17112-
resolve: "npm:^1.22.8"
17113-
tsconfig-paths: "npm:^4.2.0"
17114-
peerDependencies:
17115-
react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17116-
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17117-
storybook: ^10.2.13
17118-
vite: ^5.0.0 || ^6.0.0 || ^7.0.0
17119-
checksum: 10c0/b231b6c393007a34171ed6159a0d0a9b0870ab9058f387f714a6579ba1dbc2b533064dd6d3ba2b2d4ae48ef2b252de14344da9d0f239aee486b2dcaf3f463c66
17120-
languageName: node
17121-
linkType: hard
17122-
1712317053
"@storybook/react-vite@npm:10.2.19":
1712417054
version: 10.2.19
1712517055
resolution: "@storybook/react-vite@npm:10.2.19"
@@ -17164,25 +17094,6 @@ __metadata:
1716417094
languageName: node
1716517095
linkType: hard
1716617096

17167-
"@storybook/react@npm:10.2.13":
17168-
version: 10.2.13
17169-
resolution: "@storybook/react@npm:10.2.13"
17170-
dependencies:
17171-
"@storybook/global": "npm:^5.0.0"
17172-
"@storybook/react-dom-shim": "npm:10.2.13"
17173-
react-docgen: "npm:^8.0.2"
17174-
peerDependencies:
17175-
react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17176-
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17177-
storybook: ^10.2.13
17178-
typescript: ">= 4.9.x"
17179-
peerDependenciesMeta:
17180-
typescript:
17181-
optional: true
17182-
checksum: 10c0/1b2fe05730605cc785bceb8ca4f538ef69c149d54c7bd9dd6981366c38801c4f632ab2343f3e358b79bde5d0a088f38bba78d9efca169e6369a5b3fbf4153726
17183-
languageName: node
17184-
linkType: hard
17185-
1718617097
"@storybook/react@npm:10.2.19":
1718717098
version: 10.2.19
1718817099
resolution: "@storybook/react@npm:10.2.19"
@@ -42739,33 +42650,6 @@ __metadata:
4273942650
languageName: node
4274042651
linkType: hard
4274142652

42742-
"storybook@npm:10.2.13":
42743-
version: 10.2.13
42744-
resolution: "storybook@npm:10.2.13"
42745-
dependencies:
42746-
"@storybook/global": "npm:^5.0.0"
42747-
"@storybook/icons": "npm:^2.0.1"
42748-
"@testing-library/jest-dom": "npm:^6.6.3"
42749-
"@testing-library/user-event": "npm:^14.6.1"
42750-
"@vitest/expect": "npm:3.2.4"
42751-
"@vitest/spy": "npm:3.2.4"
42752-
esbuild: "npm:^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0 || ^0.25.0 || ^0.26.0 || ^0.27.0"
42753-
open: "npm:^10.2.0"
42754-
recast: "npm:^0.23.5"
42755-
semver: "npm:^7.7.3"
42756-
use-sync-external-store: "npm:^1.5.0"
42757-
ws: "npm:^8.18.0"
42758-
peerDependencies:
42759-
prettier: ^2 || ^3
42760-
peerDependenciesMeta:
42761-
prettier:
42762-
optional: true
42763-
bin:
42764-
storybook: ./dist/bin/dispatcher.js
42765-
checksum: 10c0/5ca338b707c3e7e94c16ecdcb00ca3c450157dceec758c15c416649e346e628a0e034d2265656650fc4fee4680631de7cc588e1a244e42cbb41af9416281a998
42766-
languageName: node
42767-
linkType: hard
42768-
4276942653
"storybook@npm:10.2.19":
4277042654
version: 10.2.19
4277142655
resolution: "storybook@npm:10.2.19"

0 commit comments

Comments
 (0)