Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Agent log rotation #667

Open
tosiara opened this issue Oct 2, 2020 · 1 comment · May be fixed by hashtopolis/agent-python#48
Open

[FEATURE] Agent log rotation #667

tosiara opened this issue Oct 2, 2020 · 1 comment · May be fixed by hashtopolis/agent-python#48
Labels
agent Hashtopolis Agent related enhancement Enhancement of existing features / Small addition

Comments

@tosiara
Copy link

tosiara commented Oct 2, 2020

  • Current Client version: s3-python-0.6.0.10
  • Your current Hashcat version: 0.12.0 commit 0e9047b
  • Agent's OS: Ubuntu 18

I have encountered another way when an agent may die - when system runs out of disk space

In my case I had client.log almost 5GB, deleting it and restarting solved the issue. But, probably, implementing a limit for log file or file rotation would be better.

Relevant exception call stack:

--- Logging error ---
Traceback (most recent call last):
  File "/usr/lib/python3.6/logging/__init__.py", line 998, in emit
    self.flush()
  File "/usr/lib/python3.6/logging/__init__.py", line 978, in flush
    self.stream.flush()
OSError: [Errno 28] No space left on device
Call stack:
  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "hashtopolis.zip/__main__.py", line 343, in <module>
    loop()
  File "hashtopolis.zip/__main__.py", line 162, in loop
    task.load_task()
  File "hashtopolis.zip/htpclient/task.py", line 35, in load_task
    logging.info("No task available!")
Message: 'No task available!'
Arguments: ()
No task available!
@s3inlc
Copy link
Member

s3inlc commented Dec 19, 2020

Agreed, 5GB seems to be quite big. With debug enabled it produces quite some output.
I will put it on the list and will implement something that it separates by day/month and cleans up old files.

@s3inlc s3inlc added agent Hashtopolis Agent related enhancement Enhancement of existing features / Small addition labels Dec 19, 2020
@zyronix zyronix changed the title client.log runs out of disk space and kills the agent [FEATURE] Agent log rotation Jun 16, 2023
@zyronix zyronix moved this to 🆕 New in Development Plans Jun 16, 2023
@bigpick bigpick linked a pull request Aug 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent Hashtopolis Agent related enhancement Enhancement of existing features / Small addition
Projects
💎 Feature Requests
Status: To triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rotating client.log bigpick/agent-python
2 participants
@s3inlc @tosiara