Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More NonEmpty zips #83

Closed
treeowl opened this issue Aug 21, 2022 · 8 comments
Closed

More NonEmpty zips #83

treeowl opened this issue Aug 21, 2022 · 8 comments
Labels
withdrawn Withdrawn by proposer

Comments

@treeowl
Copy link

treeowl commented Aug 21, 2022

Data.List.NonEmpty offers zip, zipWith, and unzip. Data.List, on the other hand, offers each of these up to arity 7. I propose to add all the rest for NonEmpty:

  • zip2 ... zip7
  • zipWith2 ... zipWith7
  • unzip ... unzip7
@Bodigrim
Copy link
Collaborator

@treeowl

The issue creator is responsible for seeing their proposal through.
The Core Libraries Committee's focus is around management,
not implementation: you should do the work for your own proposals
(or others' if you like them!) to show us that you think it's worth doing.

Given the state of #23, #24 and #31, could you please confirm that you have bandwidth to propose yet another one?

@Bodigrim
Copy link
Collaborator

Bodigrim commented Oct 1, 2022

I mean, I think this is a very reasonable proposal, but in the event it's accepted I really do not want to push and prod for months before it is implemented and merged. Do we have an enthusiatic volunteer with spare time to add zip{3,4,5,6,7}, zipWith{3,4,5,6,7} and unzip{3,4,5,6,7} for NonEmpty?

@Bodigrim
Copy link
Collaborator

@treeowl could you please clarify the status of this? Unless there is someone with enough bandwidth to champion the proposal and write an MR implementing it, I'll close this as abandoned in two weeks.

@treeowl
Copy link
Author

treeowl commented Nov 15, 2022

I would be happy to attempt an MR.

@Bodigrim
Copy link
Collaborator

@treeowl then please go ahead with a draft MR, which we can vote on.

@treeowl
Copy link
Author

treeowl commented Nov 20, 2022

@Bodigrim Now that I'm looking at it, I think it may actually be better to postpone implementation of these until the strictness issues have been settled. I don't really want to write a bunch of excessively lazy code or introduce a bunch of inconsistencies.

@Bodigrim
Copy link
Collaborator

Understood. Extreme laziness of Data.List.NonEmpty is quite a footgun. Would you like to make a proposal to change it?

@Bodigrim Bodigrim added the awaits-MR No GHC MR (https://gitlab.haskell.org/ghc/ghc/-/merge_requests) has been raised yet label Nov 20, 2022
@treeowl
Copy link
Author

treeowl commented Feb 28, 2023

Closing pending action on #107.

@treeowl treeowl closed this as completed Feb 28, 2023
@chshersh chshersh added withdrawn Withdrawn by proposer and removed awaits-MR No GHC MR (https://gitlab.haskell.org/ghc/ghc/-/merge_requests) has been raised yet labels Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
withdrawn Withdrawn by proposer
Projects
None yet
Development

No branches or pull requests

3 participants