-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge happy-*
library packages into a single happy
library component
#292
Comments
Wrong. I didn't say that. I said solved for. |
I am very much against this for the reasons I wrote in #293 (review) (I keep on seeing the PRs first before the issues, sorry.) |
Fair enough. Sorry for misquoting you. Compile-times are not an issue with
I honestly don't see what could "bleed back together" here, or what improved since the package split happened in the first place, apart from a proper module hierarchy. What concrete evidence can you point to that justifies the increased maintenance overhead? Do note that the original motivation was reuse (in |
Let me flip this around. If we do multiple libraries in a single package, what evidence is there for concrete overhead? If no one wants to use new features like multi-package Now, because we've had the multiple libraries, things have not bled back together. So I have no evidence of this happening in happy since the split, nor should I, because the remedy is in place. However, I've seen numerous examples of the architecture going to shit in many other projects, including GHC, projects at work, etc. etc. I can't share the work ones publicly but you can ask me privately if you like. I always hoped that |
Closed in favor of the design described in #288 (comment). |
Triggered by the discussion in #288, we found that it would be preferable to merge all
happy-*
library packages into the library component associated with thehappy
executable. The reasons are:happy-*
packages public library components ofhappy
? #288).happy
does not have many dependencies, so there is almost no added value of splitting it into several libraries. For example,happy-backend-lalr
does not take much longer to compile thanhappy-grammar
.but none of the compilation time benefits apply because all components are built anywayEdit: wrong according to @phadej; see below. However, multiple public components might also be less well supported bystack
andnix
.I will prepare a PR.
The text was updated successfully, but these errors were encountered: