revert performance regression

Filters still required for interfaces due to default and static methods

Author: hcoles

pitest-entry/src/main/java/org/pitest/mutationtest/build/intercept/equivalent/EqualsPerformanceShortcutFilter.java

@@ -8,6 +8,7 @@
 import static org.pitest.bytecode.analysis.OpcodeMatchers.POP2;
 
 import java.util.Collection;
+import java.util.Collections;
 import java.util.List;
 import java.util.Optional;
 import java.util.function.Predicate;
@@ -62,12 +63,6 @@ public void begin(ClassTree clazz) {
   public Collection<MutationDetails> intercept(
       Collection<MutationDetails> mutations, Mutater m) {
 
-    // skip for mutations to annotations on interfaces
-    // to avoid generating empty method warnings.
-    if (this.currentClass.isInterface()) {
-      return mutations;
-    }
-
    final List<MutationDetails> doNotTouch = mutations.stream()
            .filter(inEqualsMethod().negate())
            .collect(Collectors.toList());
@@ -101,7 +96,7 @@ private Predicate<MutationDetails> isShortcutEquals(final MethodTree tree, final
 
   private boolean shortCutEquals(MethodTree tree, MutationDetails a, Mutater m) {
     if (tree.instructions().isEmpty()) {
-      Log.getLogger().warning(tree.asLocation() + " has no instructions");
+      // occurs for mutations to annotations on interfaces
       return false;
     }
 

pitest-entry/src/main/java/org/pitest/mutationtest/build/intercept/javafeatures/ForEachLoopFilter.java

@@ -185,12 +185,6 @@ public void begin(ClassTree clazz) {
   public Collection<MutationDetails> intercept(
       Collection<MutationDetails> mutations, Mutater m) {
 
-    // skip for mutations to annotations on interfaces
-    // to avoid generating empty method warnings.
-    if (this.currentClass.isInterface()) {
-      return mutations;
-    }
-
     return mutations.stream().filter(mutatesIteratorLoopPlumbing().negate())
             .collect(Collectors.toList());
   }
@@ -205,7 +199,7 @@ private Predicate<MutationDetails> mutatesIteratorLoopPlumbing() {
       MethodTree method = maybeMethod.get();
 
       if (method.instructions().isEmpty()) {
-        Log.getLogger().warning(method.asLocation() + " has no instructions");
+        // occurs for mutations to annotations on interfaces
         return false;
       }
 

pitest-entry/src/main/java/org/pitest/mutationtest/build/intercept/timeout/AvoidForLoopCounterFilter.java

@@ -21,6 +21,7 @@
 import static org.pitest.sequence.Result.result;
 
 import java.util.Collection;
+import java.util.Collections;
 import java.util.IdentityHashMap;
 import java.util.Map;
 import java.util.Optional;
@@ -153,12 +154,6 @@ public void begin(ClassTree clazz) {
   public Collection<MutationDetails> intercept(
       Collection<MutationDetails> mutations, Mutater m) {
 
-    // skip for mutations to annotations on interfaces
-    // to avoid generating empty method warnings.
-    if (this.currentClass.isInterface()) {
-      return mutations;
-    }
-
     return mutations.stream()
             .filter(mutatesAForLoopCounter().negate())
             .collect(Collectors.toList());
@@ -173,7 +168,7 @@ private Predicate<MutationDetails> mutatesAForLoopCounter() {
       }
       MethodTree method = maybeMethod.get();
       if (method.instructions().isEmpty()) {
-        Log.getLogger().warning(method.asLocation() + " has no instructions");
+        // occurs for mutations to annotations on interfaces
         return false;
       }
 

pitest-entry/src/main/java/org/pitest/mutationtest/build/intercept/timeout/InfiniteLoopFilter.java

@@ -44,12 +44,6 @@ public void begin(ClassTree clazz) {
   public Collection<MutationDetails> intercept(
       Collection<MutationDetails> mutations, Mutater m) {
 
-    // skip for mutations to annotations on interfaces
-    // to avoid generating empty method warnings.
-    if (this.currentClass.isInterface()) {
-      return mutations;
-    }
-
     final Map<Location,Collection<MutationDetails>> buckets = FCollection.bucket(mutations, mutationToLocation());
 
     final List<MutationDetails> willTimeout = new ArrayList<>();
@@ -69,7 +63,7 @@ private Collection<MutationDetails> findTimeoutMutants(Location location,
     }
     MethodTree method = maybeMethod.get();
     if (method.instructions().isEmpty()) {
-      Log.getLogger().warning(method.asLocation() + " has no instructions");
+      // occurs for mutations to annotations on interfaces
       return Collections.emptyList();
     }