Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: replace parameters by inputs in module hdmi.sv #7

Open
LMN128 opened this issue Apr 15, 2020 · 2 comments
Open

improvement: replace parameters by inputs in module hdmi.sv #7

LMN128 opened this issue Apr 15, 2020 · 2 comments

Comments

@LMN128
Copy link

LMN128 commented Apr 15, 2020

Hi Sameer, I only propose to replace parameters in hdmi.sv module by inputs. It will be more handy for implementation. These values is useful to change as a option in project mainly:

VIDEO_ID_CODE
DVI_OUTPUT
VIDEO_REFRESH_RATE

Thanks a lot.

@sameer
Copy link
Member

sameer commented Apr 16, 2020

Hi Jan,

If VIDEO_ID_CODE is changed at runtime, are you going to update the pixel clock frequencies in the PLLs? Otherwise it would not work as an input.

For DVI_OUTPUT, are you deciding at runtime whether to output DVI or HDMI, depending on which the monitor supports?

The video refresh rate parameter does NOT change the refresh rate, it is used in audio clock calculations. If the refresh rate is 50Hz, 59,94Hz, 120Hz, etc. the audio will sound right as long as it is set correctly. It's floating point and I do not want to synthesize any floating point logic. It might be possible to encode all the possible refresh rates in an 8-bit coding though.

@LMN128
Copy link
Author

LMN128 commented Apr 26, 2020

i see, it is complicated change VIDEO_ID_CODE, but at least DVI_OUTPUT will be handy to possible change for me. Thanks

@sameer sameer closed this as completed in 416bc3e May 7, 2020
@sameer sameer reopened this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants