Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI idea] Improvements to adventures reordering #3955

Open
jpelay opened this issue Jan 18, 2023 · 5 comments
Open

[UI idea] Improvements to adventures reordering #3955

jpelay opened this issue Jan 18, 2023 · 5 comments
Assignees
@jpelay
Labels
cypress issues related to Cypress (front-end) testing

Comments

@jpelay
Copy link
Member

jpelay commented Jan 18, 2023

Idea incl level
After #3854 is merged we need to address these improvements:

Originally posted by @Felienne

Now that we have the new layout, I think we can also move quiz and puzzle into the "dragger" instead of a tickbox below?
We need to change the text for the enable/disable buttons (I can do that)
If there are no adventures available, can we remove the drowdown? And empty one is a bit weird. We can even consider a button there with "add you own"
We now have 2 places for all levels (in addition to the dragger) the top enable/disable and the dates list. Can we make that into one? Maybe just the date lists with a tick mark?

Also we need to add a Cypress test for the new drag & drop functionality!

Additional context
Add any other context about the idea here.
@jpelay jpelay self-assigned this Jan 23, 2023
@Felienne Felienne mentioned this issue Jan 24, 2023
Merged
@jpelay jpelay mentioned this issue Apr 18, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this issue May 12, 2023
@jpelay
[UI] Improvements to class customization (#4252)
670505d 
**Description**

This PR started as a way to address the issues raised in #3976 and #3955.

The improvements that has been made so far:

1. Removes the buttons in favor of a switch to disable the levels.
2. Adds a status badge to show the status of the current level we're editing.
3. _Adds button to add an adventure right in the customizations page._ (It was decided that this feature will be tackled in a future PR)
4. Removes lengthy explanation at the top of the page. 

Now, once we merged #4224 and added HTMX to Hedy, this is an opportunity to remove a large part of the Javascript code that makes this page work.

**Fixes (partially) #3976, #3955**


**How to test**

Todo: add Cypress tests

**Checklist**
Done? Check if you have it all in place using this list:*
  
- [ ] Contains one of the PR categories in the name
- [ ] Describes changes in the format above
- [ ] Links to an existing issue or discussion 
- [ ] Has a "How to test" section

If you're unsure about any of these, don't hesitate to ask. We're here to help!
@Felienne Felienne added the cypress issues related to Cypress (front-end) testing label Sep 29, 2023
@Felienne
Copy link
Member

Hi @Annelein!

Maybe many of these (or all?) have been fixed already? If so feel free to close right away.

@Annelein
Copy link
Collaborator

@jpelay I don't think there is an Cypress test for dragging the adventures right?

And then all thats left is this: If there are no adventures available, can we remove the drowdown? And empty one is a bit weird.

@jpelay
Copy link
Member Author

jpelay commented May 23, 2024

@jpelay I don't think there is an Cypress test for dragging the adventures right?

No, we used to use our own solution for the dragging and dropping, but we later switched to a library and it doesn't work welk with Cypress.

And then all thats left is this: If there are no adventures available, can we remove the drowdown? And empty one is a bit weird.

I think I can tackle this in #5540 or maybe in another PR but using that same element.

@Annelein
Copy link
Collaborator

Annelein commented May 27, 2024 •
edited
Loading

@jpelay allright! Should I just create a new issue for removing the dropdown?
And also a new issue for testing the drag and drop for in the future?

Then we can close this one.

@Annelein Annelein moved this to In Progress in Hedy organization board May 27, 2024
@Annelein
Copy link
Collaborator

@jpelay allright! Should I just create a new issue for removing the dropdown? And also a new issue for testing the drag and drop for in the future?

Then we can close this one.

@jpelay 👆🏼

@Annelein Annelein removed their assignment Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpelay jpelay

Labels
cypress issues related to Cypress (front-end) testing
Projects
Hedy organization board
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Felienne @jpelay @Annelein