Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unquoted string error message issues #4350

Closed
Felienne opened this issue Jun 19, 2023 · 1 comment
Closed

[BUG] Unquoted string error message issues #4350

Felienne opened this issue Jun 19, 2023 · 1 comment
Assignees
@Felienne

Comments

@Felienne
Copy link
Member

Felienne commented Jun 19, 2023 •
edited
Loading

A. Level 7 does not show a nice quote forgotten error:

image

B. Level 8 does not show a body missing error:

image

and C. (I suspect this is harder to fix) a forgotten quote in a body does not give a good error message:

image
@Felienne Felienne self-assigned this Jun 19, 2023
@Felienne Felienne mentioned this issue Jun 19, 2023
Merged
mergify bot pushed a commit that referenced this issue Jun 27, 2023
@Felienne
[FIX] Fix quote error level 7 and up and missing body level 8 (#4351)
92b27d4 
Fixes A and B of #4350

**How to test**

Tests for new cases added!
@Felienne Felienne moved this to Planned in Hedy organization board Nov 20, 2023
@Felienne Felienne changed the title [BUG] Some incorrect error messages to fix [BUG] Unquoted string error message issues Nov 30, 2023
@Felienne
Copy link
Member Author

C now also closed (because of #4786 I think) so this can be closed. B for levels 9 and up can be handled in a new issue to not make this too messy!

@Felienne Felienne moved this from Planned to Done in Hedy organization board Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Felienne Felienne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Felienne