Skip to content

Commit 3bfab28

Browse files
author
Tim Middleton
committed
Updates ater review
1 parent 947fbd3 commit 3bfab28

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

hols/grafana/README.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,13 @@ Now quit the Helidon application (^C).
128128
## Enable virtual threads metrics (Optional)
129129

130130
If you are running with JDK24, you can include additional experimental virtual threads metrics. Change directory to the cloned `helidon-labs` repository,
131-
and build using JDK24 include the following in each of the generated MP and SE `pom.xml`.
131+
and build the project using JDK24 and the following command:
132+
133+
```bash
134+
mvn clean install
135+
```
136+
137+
Then, include the following in each of the generated MP and SE `pom.xml`.
132138

133139
```xml
134140
<dependency>
@@ -240,6 +246,7 @@ cat ~/logs/helidon-quickstart-mp/access-0.log
240246
1. Start the Helidon MP application, as described in the previous step if it is not already started
241247
2. Rebuild and start the Helidon SE application using the following:
242248
```bash
249+
mvn clean install
243250
java -Xmx256m -Xmx256m -Dserver.port=8082 -jar target/quickstart-se.jar
244251
```
245252

@@ -250,6 +257,7 @@ monitoring stack in a common directory. You can find these configuration files i
250257

251258
```shell
252259
mkdir -p ~/.config
260+
cd hols/grafana/
253261
cp loki-local-config.yaml promtail-local-config.yaml prometheus.yaml ~/.config/
254262
```
255263

@@ -298,7 +306,7 @@ Once logged into Grafana:
298306

299307
1. Click the Grafana menu icon on the left to get the menu.
300308
2. Click on Add new data source
301-
3. Search for Prometheus and click on the `Prometheus` data source, then `Add new data source`. Ensure that the Connection URL is correct for your instance of Prometheus.
309+
3. Search for Prometheus and click on the `Prometheus` data source, then `Add new data source`. Ensure that the Connection URL is correct for your instance of Prometheus. **Make sure this is set as default**.
302310
4. Repeat the above for Loki.
303311

304312
The ports used by Loki and Prometheus should be the default ports.
@@ -422,7 +430,7 @@ If you wish to explore the Loki logs you can do the following in Grafana:
422430

423431
1. Open the Grafana menu at the top left, and click on `Explore`
424432
2. Select the `Loki` datasource
425-
3. Enter the following in the query and click `Run Query`
433+
3. On the right click, `Code`, and enter the following in the query and click `Run Query`
426434
`{job="helidon-quickstart-mp"}`
427435
4. You should see something similar to the following showing the collected logs:
428436
![grafana-loki.png](./images/grafana-loki.png)

0 commit comments

Comments
 (0)