Skip to content

Commit 3d1a640

Browse files
authored
Fix subscriptions URI. We no longer expose the internal file URI to the clients. (#82)
1 parent c14c2be commit 3d1a640

File tree

4 files changed

+4
-14
lines changed

4 files changed

+4
-14
lines changed

examples/calendar-application/calendar-declarative/src/main/java/io/helidon/extensions/mcp/examples/calendar/declarative/Calendar.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,21 +36,15 @@
3636
final class Calendar {
3737

3838
private final Path file;
39-
private final String uri;
4039

4140
Calendar() {
4241
try {
4342
this.file = Files.createTempFile("calendar", "-calendar");
44-
this.uri = file.toUri().toString();
4543
} catch (IOException ex) {
4644
throw new UncheckedIOException(ex);
4745
}
4846
}
4947

50-
String uri() {
51-
return uri;
52-
}
53-
5448
String readContent() {
5549
try {
5650
return Files.readString(file);

examples/calendar-application/calendar-declarative/src/main/java/io/helidon/extensions/mcp/examples/calendar/declarative/McpCalendarServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ List<McpToolContent> addCalendarEvent(McpFeatures features,
9494
progress.send(0);
9595
calendar.createNewEvent(name, date, attendees);
9696
progress.send(50);
97-
features.subscriptions().sendUpdate(calendar.uri());
97+
features.subscriptions().sendUpdate(EVENTS_URI);
9898
progress.send(100);
9999

100100
return List.of(McpToolContents.textContent("New event added to the calendar"));

examples/calendar-application/calendar/src/main/java/io/helidon/extensions/mcp/examples/calendar/AddCalendarEventTool.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
import io.helidon.extensions.mcp.server.McpToolContent;
3131
import io.helidon.extensions.mcp.server.McpToolContents;
3232

33+
import static io.helidon.extensions.mcp.examples.calendar.Calendar.EVENTS_URI;
34+
3335
/**
3436
* MCP tool to add a new Event to the calendar.
3537
*/
@@ -111,7 +113,7 @@ private List<McpToolContent> addCalendarEvent(McpRequest request) {
111113

112114
progress.send(50);
113115
calendar.createNewEvent(name, date, attendees);
114-
features.subscriptions().sendUpdate(calendar.uri());
116+
features.subscriptions().sendUpdate(EVENTS_URI);
115117
progress.send(100);
116118

117119
return List.of(McpToolContents.textContent("New event added to the calendar"));

examples/calendar-application/calendar/src/main/java/io/helidon/extensions/mcp/examples/calendar/Calendar.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,21 +36,15 @@ final class Calendar {
3636
static final String EVENTS_URI_TEMPLATE = EVENTS_URI + "/{name}";
3737

3838
private final Path file;
39-
private final String uri;
4039

4140
Calendar() {
4241
try {
4342
this.file = Files.createTempFile("calendar", "-calendar");
44-
this.uri = file.toUri().toString();
4543
} catch (IOException ex) {
4644
throw new UncheckedIOException(ex);
4745
}
4846
}
4947

50-
String uri() {
51-
return uri;
52-
}
53-
5448
String readContent() {
5549
try {
5650
return Files.readString(file);

0 commit comments

Comments
 (0)