Skip to content

Commit 94c1613

Browse files
committed
Squashable commit; addressing PR feedback
Signed-off-by: Laird Nelson <[email protected]>
1 parent 71f06eb commit 94c1613

File tree

12 files changed

+325
-764
lines changed

12 files changed

+325
-764
lines changed

docs/src/main/asciidoc/se/discovery.adoc

Lines changed: 3 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -386,9 +386,9 @@ need to configure _prefix URIs_. URIs that match no prefix will not be subject t
386386
webclient:
387387
services:
388388
discovery:
389-
properties:
390-
helidon-discovery-EXAMPLE-prefix-uri: "https://example.com:443/" # <1>
391-
helidon-discovery-TEST-prefix-uri: "https://test.example.com:443/" # <2> <3>
389+
prefix-uris:
390+
EXAMPLE: "https://example.com:443/" # <1>
391+
TEST: "https://test.example.com:443/" # <2> <3>
392392
----
393393
<1> Indicates that URIs starting with `https://example.com:443/` will be subject to discovery, using the discovery name
394394
of `EXAMPLE`
@@ -397,26 +397,6 @@ webclient:
397397
<3> URIs that begin with text other than `https://example.com:443/` or `https://test.example.com:443/` will not be
398398
subject to discovery
399399
400-
===== Complicated Discovery Names
401-
402-
To use complicated discovery names for certain prefix URIs, you can link them to specific prefix URIs as follows. This
403-
configuration strategy is primarily for cases where, for whatever reason, the discovery name is too long or complicated
404-
to appear in a property name:
405-
406-
[source,yaml]
407-
.`application.yaml`
408-
----
409-
webclient:
410-
services:
411-
discovery:
412-
properties:
413-
helidon-discovery-EXAMPLE-prefix-uri: "https://example.com:443/" # <1>
414-
helidon-discovery-EXAMPLE-name: "My Long Complicated Discovery Name" # <2>
415-
----
416-
<1> Indicates that URIs starting with `https://example.com:443/` will be subject to discovery
417-
<2> Indicates that the discovery name to use for prefix URIs identified by the
418-
`helidon-discovery-EXAMPLE-prefix-uri` property name will be `My Long Complicated Discovery Name`
419-
420400
== References
421401
422402
* link:{discovery-javadoc-base-url}/module-summary.html[Discovery Javadoc]

webclient/discovery/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<parent>
2222
<groupId>io.helidon.webclient</groupId>
2323
<artifactId>helidon-webclient-project</artifactId>
24-
<version>4.3.0-SNAPSHOT</version>
24+
<version>4.4.0-SNAPSHOT</version>
2525
</parent>
2626

2727
<artifactId>helidon-webclient-discovery</artifactId>

webclient/discovery/src/main/java/io/helidon/webclient/discovery/DefaultWebClientDiscovery.java

Lines changed: 71 additions & 124 deletions
Large diffs are not rendered by default.

webclient/discovery/src/main/java/io/helidon/webclient/discovery/WebClientDiscovery.java

Lines changed: 146 additions & 141 deletions
Large diffs are not rendered by default.

webclient/discovery/src/main/java/io/helidon/webclient/discovery/WebClientDiscoveryConfigBlueprint.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
*/
1616
package io.helidon.webclient.discovery;
1717

18+
import java.net.URI;
19+
import java.util.Map;
20+
1821
import io.helidon.builder.api.Option;
1922
import io.helidon.builder.api.Prototype;
2023
import io.helidon.discovery.Discovery;
@@ -39,6 +42,14 @@ interface WebClientDiscoveryConfigBlueprint extends Prototype.Factory<WebClientD
3942
@Option.RegistryService
4043
Discovery discovery();
4144

45+
/**
46+
* A {@link Map} of {@link URI} prefixes indexed under discovery names.
47+
*
48+
* @return the {@link Map}
49+
*/
50+
@Option.Configured
51+
Map<String, URI> prefixUris();
52+
4253
/**
4354
* The name to assign to the runtime type ({@code discovery} by default).
4455
*

webclient/discovery/src/test/java/io/helidon/webclient/discovery/ClientUriTest.java

Lines changed: 0 additions & 224 deletions
This file was deleted.

0 commit comments

Comments
 (0)