Skip to content

Commit aaaf65c

Browse files
authored
Avoid cross-test config contamination in microprofile/telemetry tests (#9685)
* Avoid cross-test config contamination * Remove exclusion of test from Windows
1 parent 30f1bf6 commit aaaf65c

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

microprofile/telemetry/pom.xml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,26 @@
152152
<configuration>
153153
<systemPropertyVariables>
154154
<otel.bsp.schedule.delay>${otel.bsp.schedule.delay}</otel.bsp.schedule.delay>
155+
<otel.sdk.disabled>false</otel.sdk.disabled>
155156
</systemPropertyVariables>
157+
<excludes>
158+
<exclude>**/AgentDetectorTest.java</exclude>
159+
</excludes>
160+
</configuration>
161+
</execution>
162+
<execution>
163+
<!--
164+
This test does not need an active OTel SDK so run it separately to prevent it from running first
165+
and leaving other tests with a no-op Otel which will cause them to fail.
166+
-->
167+
<id>agent-detector-tests</id>
168+
<goals>
169+
<goal>test</goal>
170+
</goals>
171+
<configuration>
172+
<includes>
173+
<include>**/AgentDetectorTest.java</include>
174+
</includes>
156175
</configuration>
157176
</execution>
158177
</executions>

microprofile/telemetry/src/test/java/io/helidon/microprofile/telemetry/TestTracerAtStartup.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
class TestTracerAtStartup {
3232

3333
@Test
34-
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/helidon-io/helidon/issues/9513")
3534
void checkForFullFeaturedTracerAtStartup() {
3635
assertThat("Global tracer from start-up extension",
3736
TestExtension.globalTracerAtStartup.unwrap(io.opentelemetry.api.trace.Tracer.class).getClass().getName(),

0 commit comments

Comments
 (0)