Fix charge_when_no_offer (#717)

* Fix charge_when_no_offer

* Fix status badge

Author: macpie

README.md

@@ -1,4 +1,4 @@
-# Helium Router [![Tests](https://github.com/helium/router/actions/workflows/main.yml/badge.svg)](https://github.com/helium/router/actions/workflows/main.yml)
+# Helium Router [![Tests](https://github.com/helium/router/actions/workflows/tests.yml/badge.svg)](https://github.com/helium/router/actions/workflows/tests.yml)
 
 Helium's LoRa Network Server (LNS) backend.
 

src/device/router_device_worker.erl

@@ -1569,7 +1569,7 @@ validate_frame_(Packet, PubKeyBin, HotspotRegion, Device0, OfferCache, Blockchai
 maybe_charge(Device, PayloadSize, Blockchain, PubKeyBin, PHash, OfferCache) ->
     case maps:get({PubKeyBin, PHash}, OfferCache, undefined) of
         undefined ->
-            case application:get_env(router, charge_when_no_offer, true) of
+            case charge_when_no_offer() of
                 false ->
                     Metadata = router_device:metadata(Device),
                     {Balance, Nonce} =
@@ -1587,6 +1587,14 @@ maybe_charge(Device, PayloadSize, Blockchain, PubKeyBin, PHash, OfferCache) ->
             router_console_dc_tracker:charge(Device, PayloadSize, Blockchain)
     end.
 
+-spec charge_when_no_offer() -> boolean().
+charge_when_no_offer() ->
+    case application:get_env(router, charge_when_no_offer, true) of
+        "true" -> true;
+        true -> true;
+        _ -> false
+    end.
+
 %%%-------------------------------------------------------------------
 %% @doc
 %% Check device's message queue to potentially wait or send reply