Merge pull request #1392 from herbie-fp/rival-memory-profile

Include rival memory profile in report

Author: obround

src/core/rival.rkt

@@ -128,7 +128,11 @@
     (define name (symbol->string (execution-name execution)))
     (define precision
       (- (execution-precision execution) (remainder (execution-precision execution) prec-threshold)))
-    (timeline-push!/unsafe 'mixsample (execution-time execution) name precision))
+    (timeline-push!/unsafe 'mixsample
+                           (execution-time execution)
+                           name
+                           precision
+                           (execution-memory execution)))
   (timeline-push!/unsafe 'outcomes
                          (- (current-inexact-milliseconds) start)
                          (rival-profile machine 'iterations)

src/reports/timeline.rkt

@@ -162,6 +162,8 @@
 
 (define (render-phase-mixed-sampling mixsample)
   (define total-time (apply + (map first mixsample)))
+  (define (format-memory-bytes bytes)
+    (format "~a MiB" (~r (/ bytes (expt 2 20)) #:precision '(= 1))))
   `((dt "Precisions")
     (dd (details
          (summary "Click to see histograms. Total time spent on operations: "
@@ -173,14 +175,19 @@
                         (define op (second (car rec)))
                         (define precisions (map third rec))
                         (define times (map first rec))
+                        (define memories (map fourth rec))
+
                         (define time-per-op (round (apply + times)))
+                        (define memory-per-op (apply + memories))
 
                         (list `(details (summary (code ,op)
                                                  ": "
                                                  ,(format-time time-per-op)
                                                  " ("
                                                  ,(format-percent time-per-op total-time)
-                                                 " of total)")
+                                                 " of total, "
+                                                 ,(format-memory-bytes memory-per-op)
+                                                 ")")
                                         (canvas ([id ,(format "calls-~a" n)]
                                                  [title
                                                   "Histogram of precisions of the used operation"]))

src/utils/timeline.rkt

@@ -186,7 +186,7 @@
 
 (define-timeline memory [live +] [alloc +])
 (define-timeline method [method])
-(define-timeline mixsample [time +] [function false] [precision false])
+(define-timeline mixsample [time +] [function false] [precision false] [memory +])
 (define-timeline times [time +] [input false])
 (define-timeline series [time +] [var false] [transform false])
 (define-timeline compiler [before +] [after +])