Merge pull request #1409 from herbie-fp/why-egraph-big

Fix overly-aggressive deduplicator

Author: pavpanchekha

src/core/mainloop.rkt

@@ -165,12 +165,6 @@
 
 ;; Converts a patch to full alt with valid history
 (define (reconstruct! alts)
-  ;; extracts the base expressions of a patch as a batchref
-  (define (get-starting-expr altn)
-    (match (alt-prevs altn)
-      [(list) (alt-expr altn)]
-      [(list prev) (get-starting-expr prev)]))
-
   ;; takes a patch and converts it to a full alt
   (define (reconstruct-alt altn loc0 orig)
     (let loop ([altn altn])

src/core/patch.rkt

@@ -15,7 +15,8 @@
          "rival.rkt"
          "taylor.rkt")
 
-(provide generate-candidates)
+(provide generate-candidates
+         get-starting-expr)
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;; Taylor ;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
@@ -197,6 +198,11 @@
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;; Public API ;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
+(define (get-starting-expr altn)
+  (match (alt-prevs altn)
+    [(list) (alt-expr altn)]
+    [(list prev) (get-starting-expr prev)]))
+
 (define (generate-candidates batch brfs spec-batch reducer)
   ; Starting alternatives
   (define start-altns
@@ -220,4 +226,5 @@
         (run-rr start-altns batch)
         '()))
 
-  (remove-duplicates (append evaluations rewritten approximations) #:key alt-expr))
+  (remove-duplicates (append evaluations rewritten approximations)
+                     #:key (λ (altn) (cons (alt-expr altn) (get-starting-expr altn)))))