Skip to content

Commit bdc767e

Browse files
authored
Merge pull request #1339 from herbie-fp/cleanup-report-docs
Clean up the report docs and also fix styling of actual report
2 parents 82d1c99 + c560b4d commit bdc767e

File tree

3 files changed

+14
-18
lines changed

3 files changed

+14
-18
lines changed

src/reports/resources/report.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,8 @@ section { display: flow-root; }
179179
.programs { position: relative; }
180180
.programs select { position: absolute; right: 3em; }
181181
.program { display: inline-block; text-align: left; }
182-
#precondition { padding: 0 1em 1em; margin: 0 -1em 1em; border-bottom: 2px solid white; }
183-
#precondition:before { content: "Precondition"; float: left; color: #444; }
182+
#precondition { margin: 2em 0; }
183+
#precondition:before { content: "Precondition:"; display: block; color: #444; margin-left: -2em; }
184184
/* Allow line breaks in display equations (see https://katex.org/docs/issues.html) */
185185
.katex-display > .katex { white-space: normal }
186186
.katex-display .base { margin: 0.25em 0 }

www/doc/2.2/report.html

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,6 @@ <h2 id="spec">Specification</h2>
7373
<p>You can use the drop-down in the top left to display the
7474
specification in an alternative syntax.</p>
7575

76-
<p>The colored outcome bar summarizes the sampled floating-point
77-
inputs that produce valid, unknown, or invalid outputs. Green
78-
outcomes are valid, broken down into finite and infinite. Unknown
79-
outputs are red. Blue outcomes are invalid (fail precondition or
80-
domain errors) and are ignored by Herbie.</p>
81-
8276
<!-- Colors copied from src/web/resources/report.css -->
8377
<h2 id="graph">Local Percentage Accuracy graph</h2>
8478

@@ -147,14 +141,13 @@ <h2 id="alternatives">Initial program and Alternatives</h2>
147141
<p>The accuracy and relative speed of each alternative is given in
148142
the title. Below the title, the alternative expression itself is
149143
given. The dropdown in the top right can be used to change the
150-
syntax used.</p>
151-
152-
<p>By definition, the speed of the initial program is 1.0×, and it
153-
has no derivation since it was provided by the user.</p>
144+
syntax used. If Herbie could not come up with anything better than
145+
the initial program, no alternatives are displayed.</p>
154146

155147
<p>Each alternative also has a derivation, which can be shown by
156148
clicking on "Derivation". The derivation shows each step Herbie
157-
took to transform the initial program into this alternative.</p>
149+
took to transform the initial program into this alternative. The
150+
initial program has no derivation.</p>
158151

159152
<figure>
160153
<img width="100%" src="report-alternative-derivation.png" />
@@ -163,9 +156,8 @@ <h2 id="alternatives">Initial program and Alternatives</h2>
163156
<p>Each step in the derivation gives the accuracy after that step.
164157
Sometimes you can use that to pick a less-complex and
165158
not-substantially-less-accurate program. The derivation will also
166-
call out any time the input is split into cases. When a part of
167-
the step is colored blue, that identifies the changed part of the
168-
expression.</p>
159+
call out any case splits. When a part of the step is colored blue,
160+
that identifies the changed part of the expression.</p>
169161

170162
<p>Derivations may also contain "step-by-step derivations"; you can
171163
click on those step-by-step derivations to expand them. Each step in
@@ -177,10 +169,14 @@ <h2 id="alternatives">Initial program and Alternatives</h2>
177169
<img width="100%" src="report-step-by-step.png" />
178170
</figure>
179171

172+
<p>Derivations are intended to give you more confidence in Herbie's
173+
results and are not guaranteed to be an accurate reflection of
174+
Herbie's internal process of constructing an alternative.</p>
175+
180176
<h2 id="reproduction">Reproduction</h2>
181177

182-
<p>Finally, Herbie gives a command to reproduce that result. If you
183-
find a Herbie bug, include this code snippet when
178+
<p>Finally, Herbie gives a command you can run to reproduce its
179+
result. If you find a Herbie bug, include this code snippet when
184180
<a href="https://github.com/uwplse/herbie/issues">filing an issue</a>.</p>
185181

186182
<figure>

www/doc/2.2/specification.png

11.8 KB
Loading

0 commit comments

Comments
 (0)