Merge branch 'main' into herbie20-crash

Author: JonasRegehr

.github/workflows/distribute.yml

@@ -15,7 +15,7 @@ jobs:
         include:
           - os: macos-latest
             arch: aarch64
-          - os: macos-13
+          - os: macos-15-intel
             arch: x64
           - os: ubuntu-latest
             arch: x64
@@ -26,9 +26,9 @@ jobs:
 
     steps:
       - name: "Install Racket"
-        uses: Bogdanp/setup-racket@v1.11
+        uses: Bogdanp/setup-racket@v1.14
         with:
-            version: "8.14"
+            version: "8.18"
             architecture: ${{ matrix.arch }}
       # WARN: need to be careful with cargo paths
       - name: Cache Racket dependencies
@@ -49,7 +49,7 @@ jobs:
         with:
             toolchain: stable
             components: rustfmt, clippy
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v5
       - name: "Install dependencies"
         run: make install
       # Build executable and remove Herbie launcher

.github/workflows/plugins.yml

@@ -13,15 +13,15 @@ jobs:
       - name: "Install Packages"
         run: sudo apt-get install -y libmpfr6 libmpfr-dev
       - name: "Install Racket"
-        uses: Bogdanp/setup-racket@v1.11
+        uses: Bogdanp/setup-racket@v1.14
         with:
-          version: "8.14"
+          version: "8.18"
       - name: Install Rust compiler
         uses: dtolnay/rust-toolchain@stable
         with:
             toolchain: stable
             components: rustfmt, clippy
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v5
       - name: "Install dependencies"
         run: make install
       - name: "Install SoftPosit support"

.github/workflows/release.yml

@@ -20,19 +20,19 @@ jobs:
           - os: macos-latest
             os-name: macOS-m1
             arch: arm64
-          - os: macos-13
+          - os: macos-15-intel
             os-name: macOS
             arch: x64
 
     runs-on: ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Install Racket
-        uses: Bogdanp/setup-racket@v1.11
+        uses: Bogdanp/setup-racket@v1.14
         with:
-          version: 8.11
+          version: 8.18
           architecture: ${{ matrix.arch }}
 
       - name: Install Rust compiler
@@ -79,7 +79,7 @@ jobs:
           merge-multiple: true
 
       - name: Create Release
-        uses: ncipollo/release-action@v1
+        uses: ncipollo/release-action@v1.20.0
         with:
           tag: ${{ github.ref }}
           name: ${{ github.ref }}

.github/workflows/resyntax-autofixer.yml

@@ -17,15 +17,15 @@ jobs:
       - name: "Install Packages"
         run: sudo apt-get install -y libmpfr6 libmpfr-dev
       - name: "Install Racket"
-        uses: Bogdanp/setup-racket@v1.11
+        uses: Bogdanp/setup-racket@v1.14
         with:
           version: current
       - name: Install Rust compiler
         uses: dtolnay/rust-toolchain@stable
         with:
             toolchain: stable
             components: rustfmt, clippy
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v5
       - name: "Install dependencies"
         run: make install
       - name: Create a Resyntax pull request

.github/workflows/tests.yml

@@ -11,21 +11,21 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        racket-version: [ '8.7', '8.14' ]
+        racket-version: [ '8.7', '8.18' ]
         precision: [ 'binary32', 'binary64' ]
     steps:
       - name: "Install Packages"
         run: sudo apt-get install -y libmpfr6 libmpfr-dev
       - name: "Install Racket"
-        uses: Bogdanp/setup-racket@v1.11
+        uses: Bogdanp/setup-racket@v1.14
         with:
           version: ${{ matrix.racket-version }}
       - name: Install Rust compiler
         uses: dtolnay/rust-toolchain@stable
         with:
             toolchain: stable
             components: rustfmt, clippy
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v5
       - name: "Install dependencies"
         run: make install
       - run: racket -y infra/ci.rkt --precision ${{ matrix.precision }} --seed 0 bench/hamming/

.github/workflows/unit-test.yml

@@ -13,15 +13,15 @@ jobs:
       - name: "Install Packages"
         run: sudo apt-get install -y libmpfr6 libmpfr-dev
       - name: "Install Racket"
-        uses: Bogdanp/setup-racket@v1.11
+        uses: Bogdanp/setup-racket@v1.14
         with:
-          version: "8.14"
+          version: "8.18"
       - name: Install Rust compiler
         uses: dtolnay/rust-toolchain@stable
         with:
             toolchain: stable
             components: rustfmt, clippy
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v5
       - name: "Install dependencies"
         run: make install
       # SoftPosit is required to test the softposit platform we use for testing
@@ -68,7 +68,7 @@ jobs:
       - run: cd egg-herbie && raco test ./
 
       # Test the API
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v6
         with:
           node-version: 20
       - name: "Test the endpoint"

AGENTS.md

@@ -8,6 +8,12 @@
 - Run `racket src/main.rkt report bench/tutorial.fpcore tmp` to test
   that your changes work; this should take about 5-10 seconds and all
   of the tests should pass, getting basically perfect accuracy.
+- After running tests, you should be able to look into `tmp`, and see
+  one directory per benchmark. Each directory has a `graph.html` with
+  more detail on what happened, including tracebacks for crashes.
+- Herbie prints a seed every time it runs; you can pass --seed N after
+  the "report" argument to fix a seed. That should be perfectly
+  reproducible.
 - You can also run the unit tests with `raco test <file>`, when unit
   tests exist. Often they don't.
 

Dockerfile

@@ -8,7 +8,7 @@ FROM rust:1.88.0 AS egg-herbie-builder
 WORKDIR /herbie
 COPY egg-herbie egg-herbie
 RUN cargo build --release --manifest-path=egg-herbie/Cargo.toml
-RUN cargo install --locked --git https://github.com/egraphs-good/egglog.git --rev 052a330de22d40e9eded19e7f0891c921f7f458c
+RUN cargo install egglog --version 1.0.0
 
 # Production image
 FROM racket/racket:8.17-full AS production

Makefile

@@ -29,7 +29,7 @@ egg-herbie:
 	raco pkg install ./egg-herbie
 
 egglog-herbie:
-	cargo install --locked --git https://github.com/egraphs-good/egglog.git --rev 052a330de22d40e9eded19e7f0891c921f7f458c
+	cargo install egglog --version 1.0.0
 
 
 distribution: minimal-distribution
@@ -45,7 +45,7 @@ minimal-distribution:
 	[ ! -f herbie.app ] || (raco distribute herbie-compiled herbie.app && rm herbie.app)
 	[ ! -f herbie ] || (raco distribute herbie-compiled herbie && rm herbie)
 
-nightly: install
+nightly:
 	bash infra/nightly.sh bench/ reports/ --threads 4
 
 upgrade:

infra/nightly.sh

@@ -4,7 +4,10 @@
 set -e -x
 
 # Ensure egglog is in the path
-export PATH="$PATH:$HOME/.cargo/bin/"
+export PATH="$HOME/.cargo/bin/:$PATH"
+rustup update
+
+make install
 
 # Seed is fixed for the whole day; this way two branches run the same seed
 SEED=$(date "+%Y%j")