eliminate mpfr-new! entirely

Author: pavpanchekha

eval/compile.rkt

@@ -296,7 +296,7 @@
                  [n (in-naturals num-vars)])
       (fn->ival-fn node
                    (lambda ()
-                     (vector-set! registers n (new-ival))
+                     (vector-set! registers n (new-ival (*rival-max-precision*)))
                      n)
                    constants-lookup
                    (- n num-vars))))

infra/run-baseline.rkt

@@ -23,6 +23,7 @@
                    registers
                    precisions
                    best-known-precisions
+                   max-precision
                    repeats
                    initial-repeats
                    default-hint
@@ -160,7 +161,7 @@
                  [n (in-naturals num-vars)])
       (fn->ival-fn node ; mappings are taken from Rival machine
                    (lambda ()
-                     (vector-set! registers n (new-ival))
+                     (vector-set! registers n (new-ival (*rival-max-precision*)))
                      n))))
 
   (define start-prec (+ (discretization-target (last discs)) 10))
@@ -181,6 +182,7 @@
                     registers
                     precisions
                     best-known-precisions
+                    (*rival-max-precision*)
                     repeats
                     initial-repeats
                     default-hint
@@ -199,6 +201,7 @@
 
 (define (baseline-apply machine pt [hint #f])
   (define discs (baseline-machine-discs machine))
+  (define max-precision (baseline-machine-max-precision machine))
   (define start-prec (+ (discretization-target (last discs)) 10))
   ; Load arguments
   (baseline-machine-load machine (vector-map ival-real pt))
@@ -212,7 +215,7 @@
       [bad? (raise (exn:rival:invalid "Invalid input" (current-continuation-marks) pt))]
       [done? fvec]
       [stuck? (raise (exn:rival:unsamplable "Unsamplable input" (current-continuation-marks) pt))]
-      [(> (* 2 prec) (*rival-max-precision*)) ; max precision is taken from eval/machine.rkt
+      [(> (* 2 prec) max-precision) ; max precision is taken from eval/machine.rkt
        (raise (exn:rival:unsamplable "Unsamplable input" (current-continuation-marks) pt))]
       [else (loop (* 2 prec) (+ iter 1))])))
 

mpfr.rkt

@@ -63,13 +63,6 @@
 
 (define mpfr-set! (get-mpfr-fun 'mpfr_set (_fun _mpfr-pointer _mpfr-pointer _rnd_t -> _void)))
 
-(define (mpfr-new! prec)
-  (unless (<= 2 prec (*rival-max-precision*))
-    (error 'mpfr-new! "Cannot create an MPFR value with precision ~a" prec))
-  (define x (parameterize ([bf-precision (*rival-max-precision*)]) (bf 0)))
-  (set-mpfr-prec! x prec)
-  x)
-
 (define mpfr-set-prec! set-mpfr-prec!)
 
 (define (bfremainder x mod)
@@ -235,5 +228,4 @@
          mpfr-mul!
          mpfr-div!
          mpfr-set-prec!
-         mpfr-new!
          mpfr-set!)

ops/arith.rkt

@@ -35,7 +35,7 @@
         (or (ival-err x) (ival-err y))))
 
 (define (ival-add x y)
-  (ival-add! (new-ival) x y))
+  (ival-add! (new-ival (bf-precision)) x y))
 
 (define (ival-sub! out x y)
   (ival (eplinear! (ival-lo-val out) mpfr-sub! (ival-lo x) (ival-hi y) 'down)
@@ -44,7 +44,7 @@
         (or (ival-err x) (ival-err y))))
 
 (define (ival-sub x y)
-  (ival-sub! (new-ival) x y))
+  (ival-sub! (new-ival (bf-precision)) x y))
 
 (define (epmul! out a-endpoint b-endpoint a-class b-class)
   (match-define (endpoint a a!) a-endpoint)
@@ -66,9 +66,10 @@
                 (and b! (bfinfinite? b) (not (= a-class 0))))))
 
 (define (ival-mult x y)
-  (ival-mult! (new-ival) x y))
+  (ival-mult! (new-ival (bf-precision)) x y))
 
-(define extra-mult-ival (new-ival))
+(define extra-mult-ival-prec (*rival-max-precision*))
+(define extra-mult-ival (new-ival extra-mult-ival-prec))
 
 (define (ival-mult! out x y)
   (match-define (ival xlo xhi xerr? xerr) x)
@@ -96,6 +97,9 @@
     ;; Here, the two branches of the union are meaningless on their own;
     ;; however, both branches compute possible lo/hi's to min/max together
     [(0 0)
+     (when (< extra-mult-ival-prec (*rival-max-precision*))
+       (set! extra-mult-ival-prec (*rival-max-precision*))
+       (set! extra-mult-ival (new-ival extra-mult-ival-prec)))
      (match-define (ival (endpoint lo lo!) (endpoint hi hi!) err? err)
        (ival-union (mkmult extra-mult-ival xhi ylo xlo ylo) (mkmult out xlo yhi xhi yhi)))
      (mpfr-set! (ival-lo-val out) lo 'down) ; should be exact
@@ -145,7 +149,7 @@
     [(0 -1) (mkdiv xhi yhi xlo yhi)]))
 
 (define (ival-div x y)
-  (ival-div! (new-ival) x y))
+  (ival-div! (new-ival (bf-precision)) x y))
 
 (define (ival-fma a b c)
   (ival-add (ival-mult a b) c))

ops/core.rkt

@@ -118,10 +118,10 @@
 (define (ival-hi-fixed? ival)
   (endpoint-immovable? (ival-hi ival)))
 
-(define (new-ival)
+(define (new-ival precision)
   ; Warning, leaks memory unless `mpfr-clear!` called eventually
-  (define bf1 (mpfr-new! (bf-precision)))
-  (define bf2 (mpfr-new! (bf-precision)))
+  (define bf1 (parameterize ([bf-precision precision]) (bf 0)))
+  (define bf2 (parameterize ([bf-precision precision]) (bf 0)))
   (ival (endpoint bf1 #f) (endpoint bf2 #f) #f #f))
 
 (define (mk-big-ival x y)