Merge pull request #137 from herbie-fp/no-heap-timing

Don't put timestamps on the heap for recording

Author: pavpanchekha

eval/run.rkt

@@ -2,7 +2,8 @@
 
 (require racket/match
          racket/function
-         racket/flonum)
+         racket/flonum
+         racket/performance-hint)
 
 (require "machine.rkt"
          "adjust.rkt"
@@ -20,22 +21,23 @@
   (set-rival-machine-bumps! machine 0)
   (*bumps-activated* #f))
 
-(define (rival-machine-record machine name number precision time memory iter)
-  (define profile-ptr (rival-machine-profile-ptr machine))
-  (define profile-instruction (rival-machine-profile-instruction machine))
-  (when (< profile-ptr (vector-length profile-instruction))
-    (define profile-number (rival-machine-profile-number machine))
-    (define profile-time (rival-machine-profile-time machine))
-    (define profile-memory (rival-machine-profile-memory machine))
-    (define profile-precision (rival-machine-profile-precision machine))
-    (define profile-iteration (rival-machine-profile-iteration machine))
-    (vector-set! profile-instruction profile-ptr name)
-    (vector-set! profile-number profile-ptr number)
-    (vector-set! profile-memory profile-ptr memory)
-    (vector-set! profile-precision profile-ptr precision)
-    (vector-set! profile-iteration profile-ptr iter)
-    (flvector-set! profile-time profile-ptr time)
-    (set-rival-machine-profile-ptr! machine (add1 profile-ptr))))
+;; Inlining critical, otherwise `time` is heap-allocated (Chez boxes floats)
+(define-inline (rival-machine-record machine name number precision time memory iter)
+               (define profile-ptr (rival-machine-profile-ptr machine))
+               (define profile-instruction (rival-machine-profile-instruction machine))
+               (when (< profile-ptr (vector-length profile-instruction))
+                 (define profile-number (rival-machine-profile-number machine))
+                 (define profile-time (rival-machine-profile-time machine))
+                 (define profile-memory (rival-machine-profile-memory machine))
+                 (define profile-precision (rival-machine-profile-precision machine))
+                 (define profile-iteration (rival-machine-profile-iteration machine))
+                 (vector-set! profile-instruction profile-ptr name)
+                 (vector-set! profile-number profile-ptr number)
+                 (vector-set! profile-memory profile-ptr memory)
+                 (vector-set! profile-precision profile-ptr precision)
+                 (vector-set! profile-iteration profile-ptr iter)
+                 (flvector-set! profile-time profile-ptr time)
+                 (set-rival-machine-profile-ptr! machine (add1 profile-ptr))))
 
 (define (rival-machine-run machine vhint)
   (define ivec (rival-machine-instructions machine))

test.rkt

@@ -3,19 +3,7 @@
 (require racket/math
          math/base
          math/flonum
-         (only-in math/bigfloat
-                  bf>
-                  bf<
-                  bf=
-                  bf>=
-                  bf<=
-                  bf-
-                  bf+
-                  bf*
-                  bf/
-                  bfmin
-                  bfmax
-                  bfshift))
+         (only-in math/bigfloat bf> bf< bf= bf>= bf<= bf- bf+ bf* bf/ bfmin bfmax bfshift))
 (require rackunit)
 (require "main.rkt"
          "mpfr.rkt")