Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateGroup does not update maxCount value. #123

Open
trey-a-hope opened this issue Jan 15, 2025 · 1 comment
Open

updateGroup does not update maxCount value. #123

trey-a-hope opened this issue Jan 15, 2025 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@trey-a-hope
Copy link

trey-a-hope commented Jan 15, 2025

Good afternoon,

When working with groups, I've noticed that updateGroup does not update the maxCount for the group if I change that value.

For example, I have this group called TDE, that has a maxCount of 10.
Screenshot 2025-01-15 at 3 00 18 pm
Screenshot 2025-01-15 at 3 00 11 pm
Next, I call the updateGroup method, (setting the maxCount to 3).
Screenshot 2025-01-15 at 3 00 31 pm
Screenshot 2025-01-15 at 3 01 22 pm
Unfortunately, when I go to fetch the same group again, the maxCount remains at 10.
Screenshot 2025-01-15 at 3 01 33 pm

Has anyone else seen this error?

@ilmalte ilmalte self-assigned this Jan 20, 2025
@ilmalte ilmalte added the type: bug Something isn't working label Jan 20, 2025
@ilmalte
Copy link
Collaborator

ilmalte commented Feb 21, 2025

I reviewed the parameters available for the UpdateGroup operation, and it appears that updating maxCount is not possible.

So, I can confirm that this is a bug—the SDK methods for updating a group should not expose the maxCount field.

Thank you very much for reporting this issue!

While investigating, I also discovered another related problem: the required fields in the updateGroup method in the Dart code are incorrect. Open should not be required but language and groupName should be.

I’ll submit a PR over the weekend to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants