Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Madewithlau.com recipe support #1015

Closed
kdliu86 opened this issue Mar 11, 2024 · 2 comments · Fixed by #1068
Closed

Madewithlau.com recipe support #1015

kdliu86 opened this issue Mar 11, 2024 · 2 comments · Fixed by #1068
Assignees
Labels

Comments

@kdliu86
Copy link

kdliu86 commented Mar 11, 2024

Currently cannot scrape madewithlau.com

https://www.madewithlau.com/recipes/siu-yuk-crispy-pork-belly

`returned scraper data for reference:

{
'author': None,
'canonical_url': 'https://www.madewithlau.com/recipes/siu-yuk-crispy-pork-belly',
'category': None,
'host': 'madewithlau.com',
'image': None,
'ingredient_groups': [{'ingredients': [], 'purpose': None}],
'ingredients': [],
'instructions': '',
'instructions_list': [],
'site_name': None
}`

@mlduff
Copy link
Contributor

mlduff commented Apr 16, 2024

It looks like madewithlau is now using a tRPC endpoint to get the recipe data after page load. An example of this is https://www.madewithlau.com/api/trpc/recipe.bySlug?batch=1&input={%220%22:{%22json%22:{%22slug%22:%22salted-fish-chicken-fried-rice%22}}}

I think that this will require a rewrite of the scraper to address, I'm happy to do this in a similar manner to how I tackled bergamot in https://github.com/hhursev/recipe-scrapers/pull/1064\

Do these findings and approach sound reasonable @jayaddison ?

@jayaddison
Copy link
Collaborator

That seems fine to me @mlduff, yep - please note that I'm going to be a little slow responding to code reviews for a few days (there are a few existing pull requests that I have not yet reviewed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants