Skip to content

Commit 77e8e77

Browse files
friedgerfriedger
committed
feat: add test showing the crash
1 parent 2d31663 commit 77e8e77

6 files changed

+424
-37
lines changed

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"description": "",
55
"scripts": {
66
"build": "tsc --build",
7-
"test:dev": "vitest",
7+
"test:dev": "vitest --run direct-stacking-with-bug",
88
"test:ci": "jest --bail=1 --silent=false",
99
"fmt:check": "./node_modules/.bin/prettier --check .",
1010
"fmt": "./node_modules/.bin/prettier --write ."

‎settings/Devnet.toml

+1-36
Original file line numberDiff line numberDiff line change
@@ -30,44 +30,9 @@ balance = 100_000_000_000_000
3030
# stx_address: ST2JHG361ZXG51QTKY2NQCVBPPRRE2KZB1HR05NNC
3131
# btc_address: mvZtbibDAAA3WLpY7zXXFqRa3T4XSknBX7
3232

33-
[accounts.wallet_4]
34-
mnemonic = "board list obtain sugar hour worth raven scout denial thunder horse logic fury scorpion fold genuine phrase wealth news aim below celery when cabin"
35-
balance = 100_000_000_000_000
36-
# secret_key: f9d7206a47f14d2870c163ebab4bf3e70d18f5d14ce1031f3902fbbc894fe4c701
37-
# stx_address: ST2NEB84ASENDXKYGJPQW86YXQCEFEX2ZQPG87ND
38-
# btc_address: mg1C76bNTutiCDV3t9nWhZs3Dc8LzUufj8
39-
40-
[accounts.wallet_5]
41-
mnemonic = "hurry aunt blame peanut heavy update captain human rice crime juice adult scale device promote vast project quiz unit note reform update climb purchase"
42-
balance = 100_000_000_000_000
43-
# secret_key: 3eccc5dac8056590432db6a35d52b9896876a3d5cbdea53b72400bc9c2099fe801
44-
# stx_address: ST2REHHS5J3CERCRBEPMGH7921Q6PYKAADT7JP2VB
45-
# btc_address: mweN5WVqadScHdA81aATSdcVr4B6dNokqx
46-
47-
[accounts.wallet_6]
48-
mnemonic = "area desk dutch sign gold cricket dawn toward giggle vibrant indoor bench warfare wagon number tiny universe sand talk dilemma pottery bone trap buddy"
49-
balance = 100_000_000_000_000
50-
# secret_key: 7036b29cb5e235e5fd9b09ae3e8eec4404e44906814d5d01cbca968a60ed4bfb01
51-
# stx_address: ST3AM1A56AK2C1XAFJ4115ZSV26EB49BVQ10MGCS0
52-
# btc_address: mzxXgV6e4BZSsz8zVHm3TmqbECt7mbuErt
53-
54-
[accounts.wallet_7]
55-
mnemonic = "prevent gallery kind limb income control noise together echo rival record wedding sense uncover school version force bleak nuclear include danger skirt enact arrow"
56-
balance = 100_000_000_000_000
57-
# secret_key: b463f0df6c05d2f156393eee73f8016c5372caa0e9e29a901bb7171d90dc4f1401
58-
# stx_address: ST3PF13W7Z0RRM42A8VZRVFQ75SV1K26RXEP8YGKJ
59-
# btc_address: n37mwmru2oaVosgfuvzBwgV2ysCQRrLko7
60-
61-
[accounts.wallet_8]
62-
mnemonic = "female adjust gallery certain visit token during great side clown fitness like hurt clip knife warm bench start reunion globe detail dream depend fortune"
63-
balance = 100_000_000_000_000
64-
# secret_key: 6a1a754ba863d7bab14adbbc3f8ebb090af9e871ace621d3e5ab634e1422885e01
65-
# stx_address: ST3NBRSFKX28FQ2ZJ1MAKX58HKHSDGNV5N7R21XCP
66-
# btc_address: n2v875jbJ4RjBnTjgbfikDfnwsDV5iUByw
67-
6833
[accounts.faucet]
6934
mnemonic = "shadow private easily thought say logic fault paddle word top book during ignore notable orange flight clock image wealth health outside kitten belt reform"
70-
balance = 100_000_000_000_000
35+
balance = 1_000_000_000_000_000
7136
# secret_key: de433bdfa14ec43aa1098d5be594c8ffb20a31485ff9de2923b2689471c401b801
7237
# stx_address: STNHKEPYEPJ8ET55ZZ0M5A34J0R3N5FM2CMMMAZ6
7338
# btc_address: mjSrB3wS4xab3kYqFktwBzfTdPg367ZJ2d

‎tests/integration/constants.ts

+6
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,10 @@ export namespace Accounts {
4242
secretKey:
4343
"d655b2523bcd65e34889725c73064feb17ceb796831c0e111ba1a552b0f31b3901",
4444
};
45+
export const FAUCET = {
46+
stxAddress: "STNHKEPYEPJ8ET55ZZ0M5A34J0R3N5FM2CMMMAZ6",
47+
btcAddress: "mjSrB3wS4xab3kYqFktwBzfTdPg367ZJ2d",
48+
secretKey:
49+
"de433bdfa14ec43aa1098d5be594c8ffb20a31485ff9de2923b2689471c401b801",
50+
};
4551
}

‎tests/integration/pox/stacking/direct-stacking-good-order.spec.ts

+122
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,122 @@
1+
import { DevnetNetworkOrchestrator } from "@hirosystems/stacks-devnet-js";
2+
import { StacksTestnet } from "@stacks/network";
3+
import { Accounts } from "../../constants";
4+
import {
5+
buildDevnetNetworkOrchestrator,
6+
getNetworkIdFromEnv,
7+
waitForStacksTransaction,
8+
} from "../../helpers";
9+
import {
10+
getPoxInfo,
11+
waitForNextRewardPhase,
12+
waitForRewardCycleId,
13+
readRewardCyclePoxAddressList,
14+
} from "../helpers";
15+
import {
16+
broadcastStackIncrease,
17+
broadcastStackSTX,
18+
} from "../helpers-direct-stacking";
19+
import {
20+
OptionalCV,
21+
SomeCV,
22+
TupleCV,
23+
cvToString,
24+
hexToCV,
25+
} from "@stacks/transactions";
26+
27+
describe("testing solo stacker increase without bug", () => {
28+
let orchestrator: DevnetNetworkOrchestrator;
29+
let timeline = {
30+
epoch_2_0: 100,
31+
epoch_2_05: 102,
32+
epoch_2_1: 106,
33+
pox_2_activation: 109,
34+
};
35+
36+
beforeAll(() => {
37+
orchestrator = buildDevnetNetworkOrchestrator(getNetworkIdFromEnv());
38+
orchestrator.start();
39+
});
40+
41+
afterAll(() => {
42+
orchestrator.terminate();
43+
});
44+
45+
it("using stacks-increase in the same cycle should result in increased rewards", async () => {
46+
const network = new StacksTestnet({ url: orchestrator.getStacksNodeUrl() });
47+
48+
// Wait for Stacks genesis block
49+
await orchestrator.waitForNextStacksBlock();
50+
// Wait for block N+1 where N is the height of the next reward phase
51+
await waitForNextRewardPhase(network, orchestrator, 1);
52+
53+
const blockHeight = timeline.pox_2_activation + 1;
54+
const fee = 1000;
55+
const cycles = 1;
56+
57+
// Bob stacks 30m
58+
let response = await broadcastStackSTX(
59+
2,
60+
network,
61+
30_000_000_000_010,
62+
Accounts.WALLET_2,
63+
blockHeight,
64+
cycles,
65+
fee,
66+
0
67+
);
68+
expect(response.error).toBeUndefined();
69+
70+
// Bob increases by 20m
71+
response = await broadcastStackIncrease(
72+
network,
73+
20_000_000_000_100,
74+
Accounts.WALLET_2,
75+
fee,
76+
1
77+
);
78+
expect(response.error).toBeUndefined();
79+
80+
// let Bob's stacking confirm to enforce reward index 0
81+
await waitForStacksTransaction(orchestrator, response.txid);
82+
83+
// Alice stacks 50m
84+
response = await broadcastStackSTX(
85+
2,
86+
network,
87+
50_000_000_000_001,
88+
Accounts.WALLET_1,
89+
blockHeight,
90+
cycles,
91+
fee,
92+
0
93+
);
94+
expect(response.error).toBeUndefined();
95+
96+
await orchestrator.waitForStacksBlockIncludingTransaction(response.txid);
97+
let poxInfo = await getPoxInfo(network);
98+
99+
// Asserts about pox info for better knowledge sharing
100+
expect(poxInfo.contract_id).toBe("ST000000000000000000002AMW42H.pox-2");
101+
expect(poxInfo.pox_activation_threshold_ustx).toBe(50_286_942_145_278);
102+
expect(poxInfo.current_cycle.id).toBe(1);
103+
expect(poxInfo.current_cycle.min_threshold_ustx).toBe(20_960_000_000_000);
104+
105+
// Assert that the next cycle has 100m STX locked
106+
expect(poxInfo.current_cycle.stacked_ustx).toBe(0);
107+
expect(poxInfo.current_cycle.is_pox_active).toBe(false);
108+
expect(poxInfo.next_cycle.stacked_ustx).toBe(100_000_000_000_111);
109+
110+
const poxAddrInfo0 = await readRewardCyclePoxAddressList(network, 2, 0);
111+
const poxAddrInfo0CV = hexToCV(poxAddrInfo0.data) as SomeCV<TupleCV>;
112+
const poxAddrInfoStr0 = cvToString(hexToCV(poxAddrInfo0.data));
113+
// There is no bug here because total stack was 0 when stack-increase was called.
114+
expect(cvToString(poxAddrInfo0CV.value.data["total-ustx"])).toBe(
115+
"u50000000000110"
116+
);
117+
118+
const poxAddrInfo1 = await readRewardCyclePoxAddressList(network, 2, 1);
119+
const poxAddrInfoStr1 = cvToString(hexToCV(poxAddrInfo1.data));
120+
expect(poxAddrInfoStr1).toContain("(total-ustx u50000000000001)");
121+
});
122+
});

‎tests/integration/pox/stacking/direct-stacking-with-bug.spec.ts

+162
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,162 @@
1+
import { DevnetNetworkOrchestrator } from "@hirosystems/stacks-devnet-js";
2+
import { StacksTestnet } from "@stacks/network";
3+
import {
4+
SomeCV,
5+
TupleCV,
6+
UIntCV,
7+
cvToString,
8+
hexToCV,
9+
} from "@stacks/transactions";
10+
import { Accounts } from "../../constants";
11+
import {
12+
buildDevnetNetworkOrchestrator,
13+
getNetworkIdFromEnv,
14+
waitForStacksTransaction,
15+
} from "../../helpers";
16+
import {
17+
getPoxInfo,
18+
readRewardCyclePoxAddressList,
19+
waitForNextRewardPhase,
20+
} from "../helpers";
21+
import {
22+
broadcastStackIncrease,
23+
broadcastStackSTX,
24+
} from "../helpers-direct-stacking";
25+
26+
describe("testing solo stacker increase without bug", () => {
27+
let orchestrator: DevnetNetworkOrchestrator;
28+
let timeline = {
29+
epoch_2_0: 100,
30+
epoch_2_05: 102,
31+
epoch_2_1: 106,
32+
pox_2_activation: 109,
33+
};
34+
35+
beforeAll(() => {
36+
orchestrator = buildDevnetNetworkOrchestrator(getNetworkIdFromEnv());
37+
orchestrator.start();
38+
});
39+
40+
afterAll(() => {
41+
orchestrator.terminate();
42+
});
43+
44+
it("using stacks-increase in the same cycle should result in increased rewards", async () => {
45+
const network = new StacksTestnet({ url: orchestrator.getStacksNodeUrl() });
46+
47+
// Wait for Stacks genesis block
48+
await orchestrator.waitForNextStacksBlock();
49+
// Wait for block N+1 where N is the height of the next reward phase
50+
await waitForNextRewardPhase(network, orchestrator, 1);
51+
52+
const blockHeight = timeline.pox_2_activation + 1;
53+
const fee = 1000;
54+
const cycles = 1;
55+
56+
// Alice stacks 900m (1/4 of liquid suply)
57+
let response = await broadcastStackSTX(
58+
2,
59+
network,
60+
900_000_000_000_001,
61+
Accounts.FAUCET,
62+
blockHeight,
63+
cycles,
64+
fee,
65+
0
66+
);
67+
expect(response.error).toBeUndefined();
68+
69+
// let Alice's stacking confirm to enforce reward index 0
70+
await waitForStacksTransaction(orchestrator, response.txid);
71+
72+
// Bob stacks 80m
73+
response = await broadcastStackSTX(
74+
2,
75+
network,
76+
80_000_000_000_010,
77+
Accounts.WALLET_2,
78+
blockHeight,
79+
cycles,
80+
fee,
81+
0
82+
);
83+
expect(response.error).toBeUndefined();
84+
85+
// Bob increases by 10m
86+
response = await broadcastStackIncrease(
87+
network,
88+
10_000_000_000_100,
89+
Accounts.WALLET_2,
90+
fee,
91+
1
92+
);
93+
expect(response.error).toBeUndefined();
94+
// let Bobx's stacking confirm to enforce reward index 1
95+
await waitForStacksTransaction(orchestrator, response.txid);
96+
97+
// Cloe stacks 80m
98+
response = await broadcastStackSTX(
99+
2,
100+
network,
101+
80_000_000_001_000,
102+
Accounts.WALLET_3,
103+
blockHeight,
104+
cycles,
105+
fee,
106+
0
107+
);
108+
expect(response.error).toBeUndefined();
109+
110+
// Cloe increases by 10m
111+
response = await broadcastStackIncrease(
112+
network,
113+
10_000_000_010_000,
114+
Accounts.WALLET_3,
115+
fee,
116+
1
117+
);
118+
expect(response.error).toBeUndefined();
119+
await orchestrator.waitForStacksBlockIncludingTransaction(response.txid);
120+
121+
let poxInfo = await getPoxInfo(network);
122+
123+
// Asserts about pox info for better knowledge sharing
124+
expect(poxInfo.total_liquid_supply_ustx).toBe(1_405_738_842_905_579);
125+
expect(poxInfo.contract_id).toBe("ST000000000000000000002AMW42H.pox-2");
126+
expect(poxInfo.pox_activation_threshold_ustx).toBe(70_286_942_145_278);
127+
expect(poxInfo.current_cycle.id).toBe(1);
128+
expect(poxInfo.current_cycle.min_threshold_ustx).toBe(29_290_000_000_000);
129+
130+
// Assert that the next cycle has 100m STX locked
131+
expect(poxInfo.current_cycle.stacked_ustx).toBe(0);
132+
expect(poxInfo.current_cycle.is_pox_active).toBe(false);
133+
expect(poxInfo.next_cycle.stacked_ustx).toBe(1_080_000_000_011_111);
134+
135+
// Check Alice's table entry
136+
const poxAddrInfo0 = await readRewardCyclePoxAddressList(network, 2, 0);
137+
const poxAddrInfo0CV = hexToCV(poxAddrInfo0.data) as SomeCV<TupleCV>;
138+
expect((poxAddrInfo0CV.value.data["total-ustx"] as UIntCV).value).toBe(
139+
BigInt(900_000_000_000_001)
140+
);
141+
142+
// Check Bob's table entry
143+
const poxAddrInfo1 = await readRewardCyclePoxAddressList(network, 2, 1);
144+
const poxAddrInfo1CV = hexToCV(poxAddrInfo1.data) as SomeCV<TupleCV>;
145+
// HERE'S THE BUG: THIS SHOULD BE `u90000000000110`
146+
// expect(cvToString(poxAddrInfo1CV.value.data["total-ustx"])).toBe("u90000000000110");
147+
expect((poxAddrInfo1CV.value.data["total-ustx"] as UIntCV).value).toBe(
148+
BigInt(990_000_000_000_111)
149+
);
150+
// Check Cloe's table entry
151+
const poxAddrInfo2 = await readRewardCyclePoxAddressList(network, 2, 2);
152+
const poxAddrInfo2CV = hexToCV(poxAddrInfo2.data) as SomeCV<TupleCV>;
153+
// HERE'S THE BUG: THIS SHOULD BE `u90000000011000`
154+
// expect(cvToString(poxAddrInfo1CV.value.data["total-ustx"])).toBe("u90000000011000");
155+
expect((poxAddrInfo2CV.value.data["total-ustx"] as UIntCV).value).toBe(
156+
BigInt(1080_000_000_011_111)
157+
);
158+
159+
const update = await waitForNextRewardPhase(network, orchestrator, 5);
160+
console.log(update)
161+
});
162+
});

0 commit comments

Comments
 (0)