Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed Tag Closing Style #42

Open
SLiNv opened this issue Apr 14, 2017 · 0 comments
Open

Mixed Tag Closing Style #42

SLiNv opened this issue Apr 14, 2017 · 0 comments

Comments

@SLiNv
Copy link

SLiNv commented Apr 14, 2017

Hi, Thanks for making this awesome theme!
So when I was looking at index.html I found that there are mixed styles of closing a tag when a if-else statement occur. I know this is no big deal so just letting you know 😉

for example, line 51-59, <a> tag is closed in the if/else statement

{% if post.description %}
    <a href="{{ site.url }}{{ post.url }}" data-toggle="tooltip" title="{{ post.description }}" class="more-link btn btn-danger btn-large">
        <i class="fa fa-link"></i> permalink...
    </a>
{% else %}
    <a href="{{ site.url }}{{ post.url }}" data-toggle="tooltip" title="Read more about {{ post.title }}" class="more-link btn btn-danger btn-large">
        <i class="fa fa-link"></i> permalink...
    </a>
{% endif %}

one the other hand, however, on line 132-141 <h2> is closed outside.

{% if post.link %}
    <h2 class="post-title text-center super lighter">
        <a href="{{ site.url }}{{ post.url }}" style="color: #fff; background-color: #45ADA8; border-radius: 4px; padding: 10px">
            <i class="fa fa-play-circle"></i> {{ post.title }}
        </a>
{% else %}
    <h2 class="post-title text-center super lighter bordered-bottom">
        <a href="{{ site.url }}{{ post.url }}"><i class="fa fa-play-circle"></i> {{ post.title }}</a>
{% endif %}
</h2>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant