Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPEG with Large Images #186

Open
ilan-gold opened this issue May 11, 2020 · 8 comments
Open

JPEG with Large Images #186

ilan-gold opened this issue May 11, 2020 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed investigation If you're not quite sure how/if something will work and it needs to be investigated

Comments

@ilan-gold
Copy link
Collaborator

ilan-gold commented May 11, 2020 •
edited
Loading

I have not really looked into this closely but in theory a JPEG implementation for >8 bits of data exists both "server-side" and on the client so it would be great to test that out. Basically, this would involve generating a tiff or zarr with JPEG(XR/2000) that has non-standard channels (>8 bits and more or less than RGB), and then finding a client-side implementation to make it work. If this looks good in a simple case, using it with https://github.com/glencoesoftware/raw2ometiff would be great.
@ilan-gold ilan-gold added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed investigation If you're not quite sure how/if something will work and it needs to be investigated labels May 11, 2020
@anton-slashm
Copy link
Contributor

@ilan-gold is it still needed? I might try to tackle it.

@ilan-gold
Copy link
Collaborator Author

@anton-slashm of course that would be amazing!!! we would need to discuss where to store the compressor but that would be great. There's a repo that has JPEG2000 already (and I know the folks at 10X have something running as well) so it should be possible. The repo is github.com/chafey/openjpegjs but it's not on npm. Give it a go! Much appreciated!

@ilan-gold
Copy link
Collaborator Author

I think the ideal scenario would be to make this a dependent of Avivator but not Viv since people can register compressors in Viv/geotiff/zarr.

@anton-slashm
Copy link
Contributor

anton-slashm commented Jun 15, 2023 •
edited
Loading

@ilan-gold I was able to open 55 megs JPEG2000 ome.tiff generated with raw2ometiff without any issues. However, I believe this simple use case is not what you're interested in. Do you maybe have examples of non-standard .zarr files you referred to, so I could use them for testing?

@ilan-gold
Copy link
Collaborator Author

Hello @anton-slashm, sorry I was away on vacation. We would be interested in that as well. Ideally, both would be supported. This issue is so old that "non-standard" just referred to any non-brightfield microscopy (i.e., RGB). I just didn't know the word back then. How far I've come!

So if you want to make a PR, I can review.

@ilan-gold
Copy link
Collaborator Author

NOTE: We'll need test images to work with, so please either upload to the cloud and provide a URL that Avivator can point at or provide test data in a file share link. Multi-scale would be ideal so we can stress test the compressor running repeatedly/in parallel.

@anton-slashm
Copy link
Contributor

Hi @ilan-gold, I'm working on it, just takes time.

@ilan-gold
Copy link
Collaborator Author

No rush! Thank you for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed investigation If you're not quite sure how/if something will work and it needs to be investigated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilan-gold @anton-slashm