Always ensure manifest is persisted (#725)

* add test for manifest persistence

* always persist manifest on open if provided

* remove unused _manifestFlushed prop

Author: chm-diederichs

lib/core.js

@@ -49,7 +49,6 @@ module.exports = class Core {
     this.destroyed = false
     this.closed = false
 
-    this._manifestFlushed = false
     this._bitfield = null
     this._verifies = null
     this._verifiesFlushed = null
@@ -264,6 +263,14 @@ module.exports = class Core {
     // to unslab
     if (header.manifest) {
       header.manifest = Verifier.createManifest(header.manifest)
+      const tx = storage.write()
+      tx.setAuth({
+        key: header.key,
+        discoveryKey: crypto.discoveryKey(header.key),
+        manifest: header.manifest,
+        keyPair: header.keyPair
+      })
+      await tx.flush()
     }
 
     const verifier = header.manifest ? new Verifier(header.key, header.manifest, { crypto, legacy }) : null
@@ -279,8 +286,6 @@ module.exports = class Core {
     if (this.discoveryKey === null) this.discoveryKey = crypto.discoveryKey(this.key)
     if (this.id === null) this.id = z32.encode(this.key)
     if (this.manifest === null) this.manifest = this.header.manifest
-
-    this._manifestFlushed = !!header.manifest
   }
 
   async audit (opts) {
@@ -329,7 +334,6 @@ module.exports = class Core {
 
     this.compat = verifier.compat
     this.verifier = verifier
-    this._manifestFlushed = false
 
     this.replicator.onupgrade()
     this.emitManifest()

test/manifest.js

@@ -1487,6 +1487,54 @@ test('create verifier - open existing core with manifest', async function (t) {
   await compatCore.close()
 })
 
+test('manifest - persist if manifest is updated', async function (t) {
+  const keyPair = crypto.keyPair()
+
+  const manifest = Verifier.createManifest({
+    quorum: 1,
+    signers: [{
+      signature: 'ed25519',
+      publicKey: keyPair.publicKey
+    }]
+  })
+
+  const key = Verifier.manifestHash(manifest)
+  const create = await createStored(t)
+
+  {
+    const core = await create(key, { compat: false })
+    await core.ready()
+
+    t.is(core.manifest, null)
+    t.is(core.core.header.manifest, null)
+    t.alike(core.key, key)
+
+    await core.close()
+  }
+
+  {
+    const core = await create(key, { manifest, compat: false })
+    await core.ready()
+
+    t.not(core.manifest, null)
+    t.not(core.core.header.manifest, null)
+    t.alike(core.key, key)
+
+    await core.close()
+  }
+
+  {
+    const core = await create(key, { compat: false })
+    await core.ready()
+
+    t.not(core.manifest, null)
+    t.not(core.core.header.manifest, null)
+    t.alike(core.key, key)
+
+    await core.close()
+  }
+})
+
 function createMultiManifest (signers, prologue = null) {
   return {
     hash: 'blake2b',