Test fix: Clean up all tmp dirs (#719)

* Test fix: Clean up all tmp dirs

* use t.tmp throughout

Author: HDegroote

test/basic.js

@@ -1,6 +1,5 @@
 const test = require('brittle')
 const b4a = require('b4a')
-const createTempDir = require('test-tmp')
 const HypercoreStorage = require('hypercore-storage')
 
 const Hypercore = require('../')
@@ -119,7 +118,7 @@ test('createIfMissing', async function (t) {
 })
 
 test('reopen writable core', async function (t) {
-  const dir = await createTempDir(t)
+  const dir = await t.tmp()
 
   const core = new Hypercore(dir)
   await core.ready()
@@ -166,7 +165,7 @@ test('reopen writable core', async function (t) {
 })
 
 test('reopen and overwrite', async function (t) {
-  const dir = await createTempDir()
+  const dir = await t.tmp()
   let storage = null
 
   const core = new Hypercore(await open())

test/batch.js

@@ -1,5 +1,4 @@
 const test = require('brittle')
-const createTempDir = require('test-tmp')
 const b4a = require('b4a')
 
 const Hypercore = require('../')
@@ -446,7 +445,7 @@ test('encryption and bigger batches', async function (t) {
 })
 
 test('persistent batch', async function (t) {
-  const dir = await createTempDir()
+  const dir = await t.tmp()
   let storage = null
 
   const core = new Hypercore(await open())
@@ -544,7 +543,7 @@ test('batch append with huge batch', { timeout: 120000 }, async function (t) {
 })
 
 test('batch does not append but reopens', async function (t) {
-  const dir = await createTempDir(t)
+  const dir = await t.tmp()
 
   let core = new Hypercore(dir)
 

test/bench/open-close.js

@@ -1,10 +1,9 @@
 const test = require('brittle')
-const tmp = require('test-tmp')
 const b4a = require('b4a')
 const Hypercore = require('../../index.js')
 
 test('open and close', async function (t) {
-  const tmpDir = await tmp(t)
+  const tmpDir = await t.tmp()
 
   const core = new Hypercore(tmpDir)
   for (let i = 0; i < 100; i++) {

test/bench/throughput.js

@@ -1,11 +1,10 @@
 const test = require('brittle')
-const tmp = require('test-tmp')
 const b4a = require('b4a')
 const { create, replicate } = require('../helpers')
 const Hypercore = require('../../index.js')
 
 test('throughput from disk', async function (t) {
-  const dir = await tmp(t)
+  const dir = await t.tmp()
 
   const a = new Hypercore(dir)
   await a.append(new Array(20000).fill().map(() => b4a.alloc(1)))

test/bitfield.js

@@ -1,6 +1,5 @@
 const test = require('brittle')
 const b4a = require('b4a')
-const createTempDir = require('test-tmp')
 const CoreStorage = require('hypercore-storage')
 const Bitfield = require('../lib/bitfield')
 const BitInterlude = require('../lib/bit-interlude')
@@ -53,7 +52,7 @@ test('bitfield - random set and gets', async function (t) {
 })
 
 test('bitfield - reload', async function (t) {
-  const dir = await createTempDir(t)
+  const dir = await t.tmp()
 
   {
     const storage = await createStorage(t, dir)
@@ -292,7 +291,7 @@ test('bitfield - setRange over multiple pages', async function (t) {
 })
 
 async function createStorage (t, dir) {
-  if (!dir) dir = await createTempDir(t)
+  if (!dir) dir = await t.tmp()
 
   const db = new CoreStorage(dir)
 

test/clear.js

@@ -1,5 +1,4 @@
 const test = require('brittle')
-const tmp = require('test-tmp')
 const b4a = require('b4a')
 const CoreStorage = require('hypercore-storage')
 const { create, createStorage, replicate, eventFlush } = require('./helpers')
@@ -108,8 +107,8 @@ test('clear blocks with diff option', async function (t) {
 })
 
 test('clear - no side effect from clearing unknown nodes', async function (t) {
-  const storageWriter = await tmp(t)
-  const storageReader = await tmp(t)
+  const storageWriter = await t.tmp()
+  const storageReader = await t.tmp()
 
   const writer1 = new Hypercore(storageWriter)
   await writer1.append(['a', 'b', 'c', 'd']) // => 'Error: Could not load node: 1'

test/core.js

@@ -1,6 +1,5 @@
 const test = require('brittle')
 const b4a = require('b4a')
-const createTempDir = require('test-tmp')
 const CoreStorage = require('hypercore-storage')
 const { MerkleTree } = require('../lib/merkle-tree')
 const Core = require('../lib/core')
@@ -427,7 +426,7 @@ test('core - copyPrologue many', async function (t) {
 })
 
 async function create (t, opts = {}) {
-  const dir = opts.dir || await createTempDir(t)
+  const dir = opts.dir || await t.tmp()
 
   let db = null
 

test/helpers/index.js

@@ -1,11 +1,10 @@
 const Hypercore = require('../../')
-const createTempDir = require('test-tmp')
 const CoreStorage = require('hypercore-storage')
 const safetyCatch = require('safety-catch')
 const DebuggingStream = require('debugging-stream')
 
 exports.create = async function (t, ...args) {
-  const dir = await createTempDir(t)
+  const dir = await t.tmp()
 
   const db = new CoreStorage(dir)
 
@@ -18,12 +17,12 @@ exports.create = async function (t, ...args) {
 }
 
 const createStorage = exports.createStorage = async function (t, dir) {
-  if (!dir) dir = await createTempDir(t)
+  if (!dir) dir = await t.tmp()
   return new CoreStorage(dir)
 }
 
 exports.createStored = async function (t) {
-  const dir = await createTempDir(t)
+  const dir = await t.tmp()
   let db = null
 
   return async function (...args) {

test/manifest.js

@@ -1,7 +1,6 @@
 const test = require('brittle')
 const crypto = require('hypercore-crypto')
 const b4a = require('b4a')
-const tmpDir = require('test-tmp')
 const c = require('compact-encoding')
 
 const Hypercore = require('../')
@@ -710,7 +709,7 @@ test('multisig - multiple appends', async function (t) {
 })
 
 test('multisig - persist to disk', async function (t) {
-  const dir = await tmpDir(t)
+  const dir = await t.tmp()
   const storage = await createStorage(t, dir)
 
   const signers = []

test/purge.js

@@ -1,12 +1,11 @@
 const test = require('brittle')
-const tmp = require('test-tmp')
 const fs = require('fs')
 const Path = require('path')
 
 const Hypercore = require('..')
 
 test('basic purge', async function (t) {
-  const dir = await tmp(t)
+  const dir = await t.tmp()
   const core = new Hypercore(dir)
   await core.append(['a', 'b', 'c'])
 
@@ -32,7 +31,7 @@ test('basic purge', async function (t) {
 })
 
 test('purge closes all sessions', async function (t) {
-  const dir = await tmp(t)
+  const dir = await t.tmp()
   const core = new Hypercore(dir)
   await core.append(['a', 'b', 'c'])
   const otherSession = core.session()