Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pyproject.toml and test with latest pip #32

Open
jlstevens opened this issue Apr 4, 2018 · 3 comments
Open

Add a pyproject.toml and test with latest pip #32

jlstevens opened this issue Apr 4, 2018 · 3 comments

Comments

@jlstevens
Copy link
Contributor

jlstevens commented Apr 4, 2018

PEP 518 is now supported by pip pypa/pip#4144 and it looks like that made it into releases of pip >= 9.0.2.

We should add a pyproject.toml to specify autover as a build dependency and test with pip + git clone. If that works, we can consider whether we should get rid of embed_version and simply raise an exception that can suggest upgrading pip to users trying to install from a git repo in this manner.

@jlstevens
Copy link
Contributor Author

Just as a reminder: if we do take this approach, autover will need to be listed as a build requirement for conda recipes.

@ceball
Copy link
Member

ceball commented Apr 4, 2018

We should add a pyproject.toml to specify autover as a build dependency and test with pip + git clone.

You're proposing to add autover as the dependency this way; if that works (i.e. works for setup.py develop, pip+git clone, etc), then would param still need to provide autover?

@jlstevens
Copy link
Contributor Author

... then would param still need to provide autover?

I think so as you still need autover as a runtime dependency, not just as a build time dependency. Of course, our packages could depend on autover but as they depend on param anyway, they would keep getting it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants