Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] : Prevent git to be used for release packages #58

Open
xavArtley opened this issue Apr 18, 2019 · 1 comment
Open

[Request] : Prevent git to be used for release packages #58

xavArtley opened this issue Apr 18, 2019 · 1 comment
Assignees

Comments

@xavArtley
Copy link

xavArtley commented Apr 18, 2019

Hi I noticed with param and panel version installed from pypi, a git cmd is used on import to retrieve the package version.

Most of the time its harmeless, but I work on a software where each time I import panel some dos cmd related to git popup.

Here is a screen shot where the .version is in the panel release

image

and a screen shot showing the 2 git cmd open at panel import. I suppose one for param and one for panel.

panel_git

the .version contain :
{"git_describe": "v0.5.1-0-g002dd94", "version_string": "0.5.1"}

I was wondering if it was possible to first check for the .version file and if not found use the git cmd?

Thx.

@ceball
Copy link
Member

ceball commented Dec 5, 2019

(edit: have turned into a summary of issues with running git on import)

[...] the code was meant to be robust against failure to launch git, and clearly it isn't yet, which we should fix rather than work around...

I think packages* should not even be trying to launch git when imported. If I install a python package (e.g. via conda or pip) and I import it, and as a side effect, "git" is run...that's very surprising to me. Not only is that surprising, though, it can cause various actual problems, e.g.

The main discussion of this topic is in #54, I think.


(* "package" is an overloaded term - I mean things installed by conda, pip, etc. I'm not concerned that git is run when I have a git checkout of param and import that.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants