Skip to content

Commit aba0268

Browse files
committed
Remove useless TODOs
1 parent b0e85e2 commit aba0268

File tree

6 files changed

+6
-676
lines changed

6 files changed

+6
-676
lines changed

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/OnboardingNavigation.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,6 @@ internal fun NavGraphBuilder.wearOnboarding(
422422
}
423423

424424
navigation<WearOnboardingRoute>(startDestination = startRoute) {
425-
// TODO discovery should be able to add existing system
426425
commonScreens(navController = navController, wearNameToOnboard = wearNameToOnboard)
427426
nameYourWearDeviceScreen(
428427
onBackClick = navController::popBackStack,
@@ -451,6 +450,5 @@ internal fun NavGraphBuilder.wearOnboarding(
451450
},
452451
onNext = onOnboardingDone,
453452
)
454-
// TODO: Consider making auth_code a value class to prevent string parameter mismatches
455453
}
456454
}

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/locationsharing/LocationSharingViewModel.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import androidx.navigation.toRoute
88
import dagger.hilt.android.lifecycle.HiltViewModel
99
import io.homeassistant.companion.android.database.sensor.SensorDao
1010
import io.homeassistant.companion.android.onboarding.locationsharing.navigation.LocationSharingRoute
11+
import io.homeassistant.companion.android.sensors.LocationSensorManager
1112
import javax.inject.Inject
1213
import kotlinx.coroutines.launch
1314
import timber.log.Timber
@@ -29,10 +30,9 @@ internal class LocationSharingViewModel @VisibleForTesting constructor(
2930
try {
3031
sensorDao.setSensorsEnabled(
3132
sensorIds = listOf(
32-
// TODO add sensor ID from `LocationSensorManager` instead of string
33-
"location_background",
34-
"zone_background",
35-
"accurate_location",
33+
LocationSensorManager.backgroundLocation.id,
34+
LocationSensorManager.zoneLocation.id,
35+
LocationSensorManager.singleAccurateLocation.id,
3636
),
3737
serverId = serverId,
3838
enabled = enabled,

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/manualserver/ManualServerScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ private fun ServerUrlTextField(
194194
if (isError) {
195195
Text(
196196
text = stringResource(commonR.string.manual_server_wrong_url),
197-
// TODO probably wrong style and color/token
198197
style = HATextStyle.BodyMedium.copy(color = LocalHAColorScheme.current.colorBorderDangerNormal),
199198
)
200199
}

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/serverdiscovery/ServerDiscoveryScreen.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,7 @@ private fun OneServerFound(
191191
imageVector = Icons.Default.Storage,
192192
contentDescription = null,
193193
modifier = Modifier
194-
.size(ICON_SIZE), // TODO double check the size of the icon within the modal
195-
// TODO change the color with proper token
194+
.size(ICON_SIZE),
196195
tint = LocalHAColorScheme.current.colorFillPrimaryLoudResting,
197196
)
198197
Text(
@@ -384,7 +383,7 @@ private fun AnimatedIcon() {
384383
.size(80.dp)
385384
.scale(pulse)
386385
.align(Alignment.Center)
387-
.background(HABrandColors.Blue, CircleShape), // TODO we might want to use a semantic token?
386+
.background(HABrandColors.Blue, CircleShape),
388387
) {
389388
Icon(
390389
imageVector = ImageVector.vectorResource(commonR.drawable.ic_stat_ic_notification_blue),

0 commit comments

Comments
 (0)