Skip to content

Commit ff7da84

Browse files
dshokouhijpelgrom
andauthored
Remove intent filter enforcement to unblock Android Auto (#5535)
* Remove intent filter enforcement to unblock Android Auto * Review comments to be less extreme and leave enforcement elsewhere * Use allowNullAction * Update baseline * Update baseline again after main merge --------- Co-authored-by: Joris Pelgröm <[email protected]>
1 parent c15909e commit ff7da84

File tree

5 files changed

+66
-54
lines changed

5 files changed

+66
-54
lines changed

app/lint-baseline.xml

Lines changed: 27 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@
107107
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
108108
<location
109109
file="src/full/AndroidManifest.xml"
110-
line="124"
110+
line="126"
111111
column="27"/>
112112
</issue>
113113

@@ -162,7 +162,7 @@
162162
errorLine2=" ^">
163163
<location
164164
file="src/full/AndroidManifest.xml"
165-
line="115"
165+
line="116"
166166
column="9"/>
167167
</issue>
168168

@@ -199,6 +199,17 @@
199199
column="13"/>
200200
</issue>
201201

202+
<issue
203+
id="UnusedAttribute"
204+
message="Attribute `intentMatchingFlags` is only used in API level 36 and higher (current min is 21)"
205+
errorLine1=" android:intentMatchingFlags=&quot;allowNullAction&quot;"
206+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
207+
<location
208+
file="src/full/AndroidManifest.xml"
209+
line="118"
210+
column="13"/>
211+
</issue>
212+
202213
<issue
203214
id="UnusedAttribute"
204215
message="Attribute `targetCellWidth` is only used in API level 31 and higher (current min is 21)"
@@ -514,7 +525,7 @@
514525
errorLine2=" ~~~~~~~~">
515526
<location
516527
file="src/full/AndroidManifest.xml"
517-
line="80"
528+
line="81"
518529
column="10"/>
519530
</issue>
520531

@@ -558,7 +569,7 @@
558569
errorLine2=" ~~~~~~~">
559570
<location
560571
file="src/full/AndroidManifest.xml"
561-
line="92"
572+
line="93"
562573
column="10"/>
563574
</issue>
564575

@@ -569,7 +580,7 @@
569580
errorLine2=" ~~~~~~~">
570581
<location
571582
file="src/full/AndroidManifest.xml"
572-
line="98"
583+
line="99"
573584
column="10"/>
574585
</issue>
575586

@@ -580,7 +591,7 @@
580591
errorLine2=" ~~~~~~~">
581592
<location
582593
file="src/full/AndroidManifest.xml"
583-
line="115"
594+
line="116"
584595
column="10"/>
585596
</issue>
586597

@@ -635,7 +646,7 @@
635646
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
636647
<location
637648
file="src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt"
638-
line="491"
649+
line="500"
639650
column="17"/>
640651
</issue>
641652

@@ -646,7 +657,7 @@
646657
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
647658
<location
648659
file="src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt"
649-
line="491"
660+
line="500"
650661
column="17"/>
651662
</issue>
652663

@@ -1308,7 +1319,7 @@
13081319
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
13091320
<location
13101321
file="src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt"
1311-
line="121"
1322+
line="122"
13121323
column="104"/>
13131324
</issue>
13141325

@@ -1319,7 +1330,7 @@
13191330
errorLine2=" ~~~~~~~~~~~~~~~">
13201331
<location
13211332
file="src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt"
1322-
line="310"
1333+
line="319"
13231334
column="52"/>
13241335
</issue>
13251336

@@ -1330,7 +1341,7 @@
13301341
errorLine2=" ~~~~~~~~~~~~~~~">
13311342
<location
13321343
file="src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt"
1333-
line="310"
1344+
line="319"
13341345
column="52"/>
13351346
</issue>
13361347

@@ -1341,7 +1352,7 @@
13411352
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
13421353
<location
13431354
file="src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt"
1344-
line="331"
1355+
line="340"
13451356
column="52"/>
13461357
</issue>
13471358

@@ -1352,7 +1363,7 @@
13521363
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
13531364
<location
13541365
file="src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt"
1355-
line="331"
1366+
line="340"
13561367
column="52"/>
13571368
</issue>
13581369

@@ -1363,7 +1374,7 @@
13631374
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
13641375
<location
13651376
file="src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt"
1366-
line="524"
1377+
line="533"
13671378
column="21"/>
13681379
</issue>
13691380

@@ -1396,7 +1407,7 @@
13961407
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
13971408
<location
13981409
file="src/main/kotlin/io/homeassistant/companion/android/webview/WebViewPresenterImpl.kt"
1399-
line="128"
1410+
line="131"
14001411
column="27"/>
14011412
</issue>
14021413

@@ -1407,7 +1418,7 @@
14071418
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
14081419
<location
14091420
file="src/main/kotlin/io/homeassistant/companion/android/webview/WebViewPresenterImpl.kt"
1410-
line="372"
1421+
line="380"
14111422
column="13"/>
14121423
</issue>
14131424

app/src/full/AndroidManifest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@
115115
android:resource="@xml/automotive_app_desc"/>
116116
<service
117117
android:name=".vehicle.HaCarAppService"
118+
android:intentMatchingFlags="allowNullAction"
118119
android:exported="true">
119120
<intent-filter>
120121
<action android:name="androidx.car.app.CarAppService" />

0 commit comments

Comments
 (0)