Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/Clean up Location Manager into more manageable pieces #1443

Open
dshokouhi opened this issue Mar 22, 2021 · 1 comment
Open

Refactor/Clean up Location Manager into more manageable pieces #1443

dshokouhi opened this issue Mar 22, 2021 · 1 comment
Labels
enhancement New feature or request location-tracking

Comments

@dshokouhi
Copy link
Member

Is your feature request related to a problem? Please describe.

The following file should be refactored/cleaned as it currently has a lot of logic and has become hard to follow overtime

https://github.com/home-assistant/android/blob/master/app/src/full/java/io/homeassistant/companion/android/sensors/LocationSensorManager.kt

Describe the solution you'd like

Clean up into more manageable pieces so its easy to follow

Describe alternatives you've considered, if any

No alternative here, we just need to make things easier on ourselves

Additional context

#1415 (review)

@dshokouhi dshokouhi added enhancement New feature or request location-tracking labels Mar 22, 2021
@stale
Copy link

stale bot commented Jan 8, 2022

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
@dshokouhi dshokouhi removed the stale label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request location-tracking
Projects
None yet
Development

No branches or pull requests

1 participant