Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TongueOut is missing in blendshapes output #1038

Open
Hakazaba opened this issue Oct 23, 2023 · 4 comments
Open

TongueOut is missing in blendshapes output #1038

Hakazaba opened this issue Oct 23, 2023 · 4 comments

Comments

@Hakazaba
Copy link

Description

Hey, im just exploring the amazing new face landmarker blendshape and matrices and i found what seems to be a little bug, the package im working from is a little bit old (#146 on linux) so it might have been fixed, but just encase it isn't i thought it worth mentioning.

The blendshape array lacks 52 - TongueOut. Likely a buffer overflow or something with the array being set to 52 instead of 53

@homuler
Copy link
Owner

homuler commented Oct 23, 2023

Could you let me know which part of the code you're referring to?

@Hakazaba
Copy link
Author

When accessing FaceLandmarkerResult.BlendShapes, it only has 52 indexes, it should have 53.

It may seem like it should be 52 according to this: https://storage.googleapis.com/mediapipe-assets/Model%20Card%20Blendshape%20V2.pdf however 0 is actually 'neutral' and not listed there. You can see this by printing the collection names of each collection in that list

@homuler
Copy link
Owner

homuler commented Oct 25, 2023

Same as google-ai-edge/mediapipe#4403

By the way, what are you talking about when you mention 'buffer overflow'? Vulnerability?

@Hakazaba
Copy link
Author

Never mind, i had thought the model would be outputting 53 blendshapes, then inserted into an array with a length of 52, thereby causing a buffer overflow and a loss of the final blendshape, due to the documentation saying there are only 52 blendshapes without including the 'neutral' blendshape at 0. It seems the problem is more endemic than that.

@homuler homuler changed the title Potential buffer overlow on face landmarker blendshape output TongueOut is missing in blendshapes output Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants