fix: resolve style conversion build issues

Author: Mike McDougall

src/Honua.Server/Features/Styling/LayerStyleService.cs

@@ -92,14 +92,14 @@ public async Task<LayerStyleUpdateResult> UpdateStyleAsync(
                 return new LayerStyleUpdateResult(LayerStyleUpdateStatus.NotFound, null, null);
             }
 
-            var drawingInfoJson = MapLibreToGeoServicesConverter.Convert(normalized, layer);
-            _ = await _styleCatalog.SetDrawingInfoAsync(layer.Id, drawingInfoJson, cancellationToken).ConfigureAwait(false);
+            var generatedDrawingInfoJson = MapLibreToGeoServicesConverter.Convert(normalized, layer);
+            _ = await _styleCatalog.SetDrawingInfoAsync(layer.Id, generatedDrawingInfoJson, cancellationToken).ConfigureAwait(false);
 
             return new LayerStyleUpdateResult(
                 LayerStyleUpdateStatus.Updated,
                 new LayerStyleSnapshot(
                     StyleJsonUtilities.ParseJsonElement(normalized),
-                    StyleJsonUtilities.ParseJsonElement(drawingInfoJson)),
+                    StyleJsonUtilities.ParseJsonElement(generatedDrawingInfoJson)),
                 null);
         }
 

src/Honua.Server/Features/Styling/MapLibreToGeoServicesConverter.cs

@@ -293,7 +293,7 @@ private static bool TryBuildPictureMarkerDrawingInfo(
         GeometryType geometryType,
         string field,
         StyleColor baseColor,
-        IReadOnlyList<ClassBreakStop> stops,
+        List<ClassBreakStop> stops,
         double? opacity,
         OutlineStyle? outline,
         double? lineWidth,

tests/Honua.Server.Tests/Features/Styling/StyleConversionMatrixTests.cs

@@ -2,7 +2,6 @@
 // Licensed under the Elastic License 2.0. See LICENSE in the project root.
 
 using System.Globalization;
-using System.Linq;
 using System.Text.Json;
 using Honua.Core.Features.Catalog.Domain;
 using Honua.Server.Features.Styling;
@@ -11,7 +10,7 @@
 namespace Honua.Server.Tests.Features.Styling;
 
 /// <summary>
-/// Tests for Esri <-> MapLibre style conversion coverage.
+/// Tests for Esri to MapLibre style conversion coverage.
 /// </summary>
 [Trait("Category", "Unit")]
 [Trait("Component", "Styling")]