fix: resolve formatting and naming warnings (#241) (#246)

* refactor: split FeatureServer handlers and services (#228)

* chore: commit all changes

* Implement GIS crosscutting updates

* Sync CODEX with CLAUDE

* chore: update server, tests, and docs

* chore: ignore cite session outputs

* chore: remove cite session artifacts

* fix: remove unused edit handler and ignore cite outputs

* fix: resolve formatting and naming warnings (#241)

* fix: align relationships seed schema (#241)

* fix(ci): stabilize js integration setup

---------

Co-authored-by: Mike McDougall <[email protected]>

Author: mikemcdougall

.devcontainer/devcontainer.json

@@ -1,9 +1,18 @@
 {
   "name": "Honua Server Development",
-  "dockerComposeFile": "../docker-compose.yml",
+  "dockerComposeFile": [
+    "../docker-compose.yml",
+    "docker-compose.emulators.yml"
+  ],
   "service": "honua",
   "workspaceFolder": "/workspace",
   "shutdownAction": "stopCompose",
+  "runServices": [
+    "honua",
+    "postgres",
+    "localstack",
+    "azurite"
+  ],
 
   // Configure properties specific to VS Code
   "customizations": {
@@ -60,13 +69,23 @@
     "DOTNET_CLI_TELEMETRY_OPTOUT": "1",
     "DOTNET_SKIP_FIRST_TIME_EXPERIENCE": "1",
     "DOTNET_NOLOGO": "1",
-    "DOTNET_RUNNING_IN_CONTAINER": "true"
+    "DOTNET_RUNNING_IN_CONTAINER": "true",
+    "HONUA_TEST_S3_BUCKET": "honua-dev-storage",
+    "HONUA_TEST_S3_REGION": "us-east-1",
+    "HONUA_TEST_S3_ACCESS_KEY": "test",
+    "HONUA_TEST_S3_SECRET_KEY": "test",
+    "HONUA_TEST_S3_SERVICE_URL": "http://localstack:4566",
+    "HONUA_TEST_S3_FORCE_PATH_STYLE": "true",
+    "HONUA_TEST_AZURE_BLOB_CONTAINER": "honua-dev-storage",
+    "HONUA_TEST_AZURE_BLOB_CONNECTION_STRING": "DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNoGV2qg3Xg0P/hy0p2w1szG+S0mJr+vX2eWq2A==;BlobEndpoint=http://azurite:10000/devstoreaccount1;"
   },
 
   // Port forwarding
   "forwardPorts": [
     8080,  // Honua Server
     5432,  // PostgreSQL
+    4566,  // Localstack
+    10000, // Azurite Blob
     3000,  // Grafana
     9090,  // Prometheus
     3100   // Loki
@@ -80,6 +99,12 @@
     "5432": {
       "label": "PostgreSQL"
     },
+    "4566": {
+      "label": "Localstack (S3)"
+    },
+    "10000": {
+      "label": "Azurite Blob"
+    },
     "3000": {
       "label": "Grafana"
     },
@@ -147,4 +172,4 @@
     "dotnet restore Honua.sln && " +
     "echo 'Dependencies updated!'"
   ]
-}
+}

.devcontainer/docker-compose.emulators.yml

@@ -0,0 +1,27 @@
+version: '3.8'
+
+services:
+  localstack:
+    image: localstack/localstack:3.6.0
+    environment:
+      SERVICES: s3
+      DEFAULT_REGION: us-east-1
+      AWS_DEFAULT_REGION: us-east-1
+      AWS_ACCESS_KEY_ID: test
+      AWS_SECRET_ACCESS_KEY: test
+    ports:
+      - "4566:4566"
+    volumes:
+      - localstack_data:/var/lib/localstack
+
+  azurite:
+    image: mcr.microsoft.com/azure-storage/azurite:3.31.0
+    command: "azurite-blob --blobHost 0.0.0.0 --blobPort 10000 --location /data --loose"
+    ports:
+      - "10000:10000"
+    volumes:
+      - azurite_data:/data
+
+volumes:
+  localstack_data:
+  azurite_data:

.github/workflows/ci.yml

@@ -286,15 +286,28 @@ jobs:
           );
 
           CREATE TABLE IF NOT EXISTS honua.relationships (
+              id SERIAL PRIMARY KEY,
               layer_id INT NOT NULL REFERENCES honua.layers(layer_id) ON DELETE CASCADE,
               relationship_id INT NOT NULL,
               name TEXT NOT NULL,
-              related_layer_id INT NOT NULL REFERENCES honua.layers(layer_id),
+              related_layer_id INT NOT NULL REFERENCES honua.layers(layer_id) ON DELETE CASCADE,
               relationship_type TEXT NOT NULL,
               origin_foreign_key TEXT NOT NULL,
               destination_foreign_key TEXT NOT NULL,
               description TEXT,
-              PRIMARY KEY (layer_id, relationship_id)
+              created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+              updated_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+              CONSTRAINT relationships_layer_relationship_unique UNIQUE(layer_id, relationship_id),
+              CONSTRAINT relationships_valid_ids CHECK(layer_id >= 0 AND related_layer_id >= 0 AND relationship_id > 0),
+              CONSTRAINT relationships_valid_fields CHECK(
+                  LENGTH(name) > 0 AND LENGTH(name) <= 128 AND
+                  LENGTH(relationship_type) > 0 AND LENGTH(relationship_type) <= 64 AND
+                  LENGTH(origin_foreign_key) > 0 AND LENGTH(origin_foreign_key) <= 128 AND
+                  LENGTH(destination_foreign_key) > 0 AND LENGTH(destination_foreign_key) <= 128
+              ),
+              CONSTRAINT relationships_valid_type CHECK(
+                  relationship_type IN ('esriRelRoleOrigin', 'esriRelRoleDestination', 'esriRelRoleAny')
+              )
           );
 
           CREATE TABLE IF NOT EXISTS features (
@@ -353,7 +366,7 @@ jobs:
               'Test Layer',
               'Default layer for integration tests',
               'features',
-              'GeometryCollection',
+              'Point',
               4326,
               true
           )
@@ -423,6 +436,8 @@ jobs:
         env:
           ConnectionStrings__DefaultConnection: "Host=localhost;Database=honua_test;Username=honua;Password=honua"
           ASPNETCORE_URLS: "http://localhost:5000"
+          Security__ConnectionEncryption__MasterKey: "test-master-key-that-is-at-least-32-characters-long-for-security"
+          Security__ConnectionEncryption__Salt: "dGVzdC1zYWx0LWZvci1lbmNyeXB0aW9uLXRlc3RpbmctcHVycG9zZXM="
 
       - name: Install JavaScript test dependencies
         run: npm ci

.github/workflows/cite-conformance.yml

@@ -77,6 +77,10 @@ jobs:
             exit 1
           fi
 
+      - name: Validate advertised conformance classes
+        run: |
+          bash ./scripts/validate-ogc-conformance.sh --results cite-results
+
       - name: Parse CITE results
         id: parse-results
         run: |
@@ -223,4 +227,4 @@ jobs:
           echo "❌ OGC CITE conformance tests failed"
           echo "Failed tests: ${{ steps.parse-results.outputs.failed_tests }}"
           echo "Review the test results and fix conformance issues"
-          exit 1
+          exit 1

.gitignore

@@ -228,6 +228,14 @@ docs/temp/
 *.local.json
 appsettings.Development.json
 !appsettings.Development.json.template
+cite-results/cite-session-*/
+cite-tiles-results/cite-tiles-session-*/
+cite-results/*
+!cite-results/cite-summary.md
+!cite-results/conformance.json
+cite-tiles-results/*
+!cite-tiles-results/cite-summary.md
+!cite-tiles-results/conformance.json
 
 # Environment files (keep examples, ignore actual configs)
 .env
@@ -241,6 +249,9 @@ appsettings.Development.json
 .serena/
 .claude/plans/
 
+# Local Python test environment
+.venv-tests/
+
 # Benchmark artifacts
 benchmarks/**/BenchmarkDotNet.Artifacts/
 
@@ -249,3 +260,8 @@ benchmarks/**/BenchmarkDotNet.Artifacts/
 
 # Coverage
 coverage*/
+
+# Local runtime/test artifacts
+tmp/
+src/Honua.Server/tmp/
+src/Honua.Server/attachments/

CLAUDE.md

@@ -6,6 +6,13 @@
 
 Honua Server is a greenfield implementation of a geospatial feature server supporting multiple protocols (GeoServices REST, OGC API Features, OData v4, MVT). This is a **clean rewrite** — the legacy codebase exists as reference only.
 
+## MVP Deferrals (Operational Simplicity)
+
+The MVP intentionally defers enterprise/operational features to reduce complexity:
+- No app-level rate limiting; enforce at the edge (nginx/ALB/WAF).
+- No secure-connection allowlist or connection audit trail; secure connections are encrypted or secret references only.
+- No security compliance framework, audit log storage, or compliance dashboards/monitoring.
+
 ## Critical Rules
 
 ### Legacy Code Reference Policy
@@ -88,6 +95,12 @@ Query_WithWhereClause_ReturnsFilteredFeatures()
 Query_InvalidSyntax_Returns400WithErrorDetails()
 ```
 
+**Scale Tests (Multi-Node + Redis)**:
+- Start the scale stack: `docker compose -f docker-compose.scale-test.yml up --build --scale honua=3`
+- Set env vars (inside the devcontainer): `HONUA_SCALE_TEST_BASE_URL=http://localhost:8080`, `HONUA_SCALE_TEST_REDIS=localhost:6379`
+- Run scale tests only: `dotnet test tests/Honua.Server.Tests/Honua.Server.Tests.csproj --filter Category=Scale`
+- Scale tests expect `docker/nginx/scale-test.conf` to emit `X-Instance-ID` for `/rest/`, `/ogc/`, and `/odata/`
+
 ### Architecture Enforcement
 
 #### BLOCKING VIOLATIONS (must fix before merge)
@@ -122,7 +135,7 @@ public class FeaturesController : ControllerBase  // BLOCKING - No controllers a
 public static void MapFeatureServerEndpoints(this WebApplication app)
 {
     app.MapGet("/rest/services/{id}/FeatureServer/{layerId}/query",
-        async (int id, int layerId, IFeatureStore store) => { });
+        async (int id, int layerId, IFeatureReader reader) => { });
 }
 ```
 
@@ -134,7 +147,7 @@ public class PostgresConnection { }       // BLOCKING - Should be internal
 
 // CORRECT: Proper encapsulation
 internal class FeatureRepository { }      // OK - Implementation details are internal
-public interface IFeatureStore { }        // OK - Abstractions can be public
+public interface IFeatureReader { }       // OK - Abstractions can be public
 ```
 
 **4. Missing documentation**
@@ -180,7 +193,7 @@ src/Honua.Server/Features/
 ```csharp
 // WARNING: Too many dependencies (endpoint limit: 5, handler limit: 4)
 public class QueryHandler(
-    IFeatureStore store,        // 1
+    IFeatureReader reader,      // 1
     ILayerCatalog catalog,      // 2
     ILogger<QueryHandler> log,  // 3
     IValidator validator,       // 4
@@ -204,13 +217,13 @@ class A : B : C : D { }  // WARNING: >3 levels, consider composition
 ```csharp
 // GOOD: Proper dependency direction
 // Honua.Core defines interface
-public interface IFeatureStore { }
+public interface IFeatureReader { }
 
 // Honua.Postgres implements interface
-internal class PostgresFeatureStore : IFeatureStore { }
+internal class PostgresFeatureStore : IFeatureReader { }
 
 // Honua.Server uses interface
-public static async Task<IResult> QueryFeatures(IFeatureStore store) { }
+public static async Task<IResult> QueryFeatures(IFeatureReader reader) { }
 ```
 
 **2. Vertical slice organization**

CODEX.md

@@ -6,6 +6,13 @@
 
 Honua Server is a greenfield implementation of a geospatial feature server supporting multiple protocols (GeoServices REST, OGC API Features, OData v4, MVT). This is a **clean rewrite** — the legacy codebase exists as reference only.
 
+## MVP Deferrals (Operational Simplicity)
+
+The MVP intentionally defers enterprise/operational features to reduce complexity:
+- No app-level rate limiting; enforce at the edge (nginx/ALB/WAF).
+- No secure-connection allowlist or connection audit trail; secure connections are encrypted or secret references only.
+- No security compliance framework, audit log storage, or compliance dashboards/monitoring.
+
 ## Critical Rules
 
 ### Legacy Code Reference Policy
@@ -88,6 +95,12 @@ Query_WithWhereClause_ReturnsFilteredFeatures()
 Query_InvalidSyntax_Returns400WithErrorDetails()
 ```
 
+**Scale Tests (Multi-Node + Redis)**:
+- Start the scale stack: `docker compose -f docker-compose.scale-test.yml up --build --scale honua=3`
+- Set env vars (inside the devcontainer): `HONUA_SCALE_TEST_BASE_URL=http://localhost:8080`, `HONUA_SCALE_TEST_REDIS=localhost:6379`
+- Run scale tests only: `dotnet test tests/Honua.Server.Tests/Honua.Server.Tests.csproj --filter Category=Scale`
+- Scale tests expect `docker/nginx/scale-test.conf` to emit `X-Instance-ID` for `/rest/`, `/ogc/`, and `/odata/`
+
 ### Architecture Enforcement
 
 #### BLOCKING VIOLATIONS (must fix before merge)
@@ -122,7 +135,7 @@ public class FeaturesController : ControllerBase  // BLOCKING - No controllers a
 public static void MapFeatureServerEndpoints(this WebApplication app)
 {
     app.MapGet("/rest/services/{id}/FeatureServer/{layerId}/query",
-        async (int id, int layerId, IFeatureStore store) => { });
+        async (int id, int layerId, IFeatureReader reader) => { });
 }
 ```
 
@@ -134,7 +147,7 @@ public class PostgresConnection { }       // BLOCKING - Should be internal
 
 // CORRECT: Proper encapsulation
 internal class FeatureRepository { }      // OK - Implementation details are internal
-public interface IFeatureStore { }        // OK - Abstractions can be public
+public interface IFeatureReader { }       // OK - Abstractions can be public
 ```
 
 **4. Missing documentation**
@@ -180,7 +193,7 @@ src/Honua.Server/Features/
 ```csharp
 // WARNING: Too many dependencies (endpoint limit: 5, handler limit: 4)
 public class QueryHandler(
-    IFeatureStore store,        // 1
+    IFeatureReader reader,      // 1
     ILayerCatalog catalog,      // 2
     ILogger<QueryHandler> log,  // 3
     IValidator validator,       // 4
@@ -204,13 +217,13 @@ class A : B : C : D { }  // WARNING: >3 levels, consider composition
 ```csharp
 // GOOD: Proper dependency direction
 // Honua.Core defines interface
-public interface IFeatureStore { }
+public interface IFeatureReader { }
 
 // Honua.Postgres implements interface
-internal class PostgresFeatureStore : IFeatureStore { }
+internal class PostgresFeatureStore : IFeatureReader { }
 
 // Honua.Server uses interface
-public static async Task<IResult> QueryFeatures(IFeatureStore store) { }
+public static async Task<IResult> QueryFeatures(IFeatureReader reader) { }
 ```
 
 **2. Vertical slice organization**